You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @ckadner sorry I didn't have time to recompile the server for every PR. Right now our CI is only catching build errors but we don't have any test to catch runtime errors. Maybe we can add a simple test just to start the server to make sure nothing is crashing the server startup? This way we don't accidentally merged critical bugs that crashes our server startup.
I was more thinking of a simple test just start the server in a Github Action, so we don't get a crashing image in our latest build. The docker compose test is nice to have, but I'm not sure can github action able to handle that many workloads.
Hi @ckadner sorry I didn't have time to recompile the server for every PR. Right now our CI is only catching build errors but we don't have any test to catch runtime errors. Maybe we can add a simple test just to start the server to make sure nothing is crashing the server startup? This way we don't accidentally merged critical bugs that crashes our server startup.
Originally posted by @Tomcli in #205 (comment)
The text was updated successfully, but these errors were encountered: