Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server stand up test as part of MLX CI #213

Open
Tomcli opened this issue Sep 15, 2021 · 3 comments
Open

Add server stand up test as part of MLX CI #213

Tomcli opened this issue Sep 15, 2021 · 3 comments
Assignees
Labels
API Swagger API help wanted Extra attention is needed size/S test

Comments

@Tomcli
Copy link
Member

Tomcli commented Sep 15, 2021

Hi @ckadner sorry I didn't have time to recompile the server for every PR. Right now our CI is only catching build errors but we don't have any test to catch runtime errors. Maybe we can add a simple test just to start the server to make sure nothing is crashing the server startup? This way we don't accidentally merged critical bugs that crashes our server startup.

Originally posted by @Tomcli in #205 (comment)

@ckadner ckadner self-assigned this Sep 15, 2021
@ckadner
Copy link
Member

ckadner commented Sep 15, 2021

@Tomcli -- so our PR builder could do this for API code changes:

  • build a new API docker image, push it
  • pull the new image image and start it -- OR -- run the Python code directly
  • with Docker Compose: upload the catalog via curl, check response code (Rework bootstrapper #23)
  • with Docker Compose: get the catalog, check response code, check number of assets is greater 0

Besides that, I still need to create unit tests from the examples I usually run as a manual test

@ckadner ckadner added API Swagger API test labels Sep 15, 2021
@Tomcli
Copy link
Member Author

Tomcli commented Sep 15, 2021

@Tomcli -- so our PR builder could do this for API code changes:

  • build a new API docker image, push it
  • pull the new image image and start it -- OR -- run the Python code directly
  • with Docker Compose: upload the catalog via curl, check response code (Rework bootstrapper #23)
  • with Docker Compose: get the catalog, check response code, check number of assets is greater 0

Besides that, I still need to create unit tests from the examples I usually run as a manual test

I was more thinking of a simple test just start the server in a Github Action, so we don't get a crashing image in our latest build. The docker compose test is nice to have, but I'm not sure can github action able to handle that many workloads.

@ckadner
Copy link
Member

ckadner commented Sep 15, 2021

starting the image after building it should be a good start -- that does not need Minio or MySQL

@ckadner ckadner added RCOS Potential work items for RCOS student interns size/S labels Sep 21, 2021
@ckadner ckadner added help wanted Extra attention is needed and removed RCOS Potential work items for RCOS student interns labels Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Swagger API help wanted Extra attention is needed size/S test
Projects
None yet
Development

No branches or pull requests

2 participants