Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject asset upload with invalid id #273

Merged
merged 6 commits into from
Feb 24, 2022
Merged

Reject asset upload with invalid id #273

merged 6 commits into from
Feb 24, 2022

Commits on Nov 23, 2021

  1. Added validate-id to __init__.py 

    Signed-off-by: JAulet <51500017+JAulet@users.noreply.github.com>
    @JAulet
    JAulet committed Nov 23, 2021
    Configuration menu
    Copy the full SHA
    5dbf8a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Added check to notebook_service_controller_impl.py 

    Signed-off-by: JAulet <51500017+JAulet@users.noreply.github.com>
    @JAulet
    JAulet committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    d3c2a59 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Merge branch 'machine-learning-exchange:main' into vald-id-only

    @JAulet
    JAulet committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    0da1604 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2022

  1. Merge branch 'machine-learning-exchange:main' into vald-id-only

    @JAulet
    JAulet committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    b3b7462 View commit details
    Browse the repository at this point in the history

  2. Added validate-id check to dataset_service_controller_impl.py and 

    model_service_controller_impl.py.

Signed-off-by: JAulet <51500017+JAulet@users.noreply.github.com>
    @JAulet
    JAulet committed Feb 15, 2022
    Configuration menu
    Copy the full SHA
    bb528c9 View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2022

  1. Moved validate_id check to before id is generated and changed function 

    call to check the id of the yaml file itself rather than generated id.

Signed-off-by: JAulet <51500017+JAulet@users.noreply.github.com>
    @JAulet
    JAulet committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    994879c View commit details
    Browse the repository at this point in the history