Disable run in Quickstart (again) #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ckadner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ckadner
commented
Dec 8, 2021
| @@ -21,7 +21,8 @@ To deploy MLX locally with Kubernetes on Docker (KIND) follow this | |||
| In a nutshell, run these two commands and bring up MLX in your browser when | |||
| you see the log message `Open the MLX Dashboard at http://localhost:80/`: | |||
|
|
|||
| wget https://raw.githubusercontent.com/machine-learning-exchange/mlx/main/quickstart/docker-compose.yaml | |||
| curl -O https://raw.githubusercontent.com/machine-learning-exchange/mlx/main/quickstart/docker-compose.yaml | |||
There was a problem hiding this comment.
curl appears to be more widely available than wget, i.e. my new Mac did not have wget but it did have curl
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After PR #281 the Quickstart started to show the
LAUNCHtabs even though themlx-uiservice hasREACT_APP_RUN: "false". So this PR is adding back the API call to disable the RUN setting.