Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Codegen for Git Bash on Windows #292

Merged
merged 1 commit into from Jan 29, 2022

Conversation

RRM123
Copy link
Contributor

@RRM123 RRM123 commented Jan 29, 2022

Resolves #291

Modified generate_code.sh and add_liscence_headers.sh under api and tools respectively to include Windows Git Bash as a valid OS Type.

F.Y.I: @ckadner

Resolves machine-learning-exchange#291

Signed-off-by: RRM123 <rithikmamidi@gmail.com>
@ckadner ckadner requested review from ckadner and JAulet and removed request for yhwang and drewbutlerbb4 January 29, 2022 00:40
@ckadner ckadner added API Swagger API good first issue Good for newcomers RCOS Potential work items for RCOS student interns labels Jan 29, 2022
Copy link
Member

@ckadner ckadner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks Rithik!

@mlx-bot
Copy link
Collaborator

mlx-bot commented Jan 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckadner, RRM123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mlx-bot mlx-bot merged commit f9c8bab into machine-learning-exchange:main Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Swagger API approved good first issue Good for newcomers lgtm RCOS Potential work items for RCOS student interns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Codegen fails on Windows Git Bash
3 participants