Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You get a warning regarding ShouldBeOfType #271

Merged
merged 1 commit into from Feb 23, 2016
Merged

You get a warning regarding ShouldBeOfType #271

merged 1 commit into from Feb 23, 2016

Conversation

wallymathieu
Copy link

In the warning the issue #171 is mentioned.

In the warning the issue #171 is mentioned.
BrunoJuchli added a commit that referenced this pull request Feb 23, 2016
Updated documentation to reflect that ShouldBeOfType is now deprecated and ShouldBeOfExactType should be used. Thanks to NameOfTheDragon.
@BrunoJuchli BrunoJuchli merged commit cdd8d63 into machine:master Feb 23, 2016
@BrunoJuchli
Copy link
Contributor

@wallymathieu thank you, i've integrated the PR.

@machine/team-machine
i'm not sure what the current process is and who is deemed "responsible" for this project. As this was a trivial change and i deemed it a sensible one i've merged this into master.
Please tell me if you mind or if you have directions on how to handle PRs

Thank you all for contributing to open source :-)

@NameOfTheDragon
Copy link
Contributor

I’m currently trying to find out who is at the helm. MSpec is too good to let it fade into obscurity and while I can’t dedicate much (or any) time to contributing code, I would be more than happy to take on the role of ‘benevolent dictator’ if that is needed to keep the project alive.

Best regards,
Tim Long

From: Bruno Juchli [mailto:notifications@github.com]
Sent: Tuesday, February 23, 2016 11:55 AM
To: machine/machine.specifications machine.specifications@noreply.github.com
Subject: Re: [machine.specifications] You get a warning regarding ShouldBeOfType (#271)

Merged #271#271.


Reply to this email directly or view it on GitHubhttps://github.com//pull/271#event-561492679.

@jfellien
Copy link

@NameOfTheDragon ‘benevolent dictator’ sounds good, but mostly I have problems with dictators ;-)

@machine/team-machine currently I'm only the contributor of mspec-light. But it seems so @danielmarbach thougth I'll take the helm. Oh no.. this ist not my intention. MSpec is a community driven project which is in the near of ending, I guess. So if we don't want that MSpec dies, we have to reorganize us.

Any Ideas @ALL?

@BrunoJuchli
Copy link
Contributor

I'm planning on starting to work on my own BDD/ATDD tool in the near future.
Why? Because i have some long-standing issues with mspec like not being able to access "this" and forcing me to use static variables all over (==> driver for test leakage). I want to have a spec-test suite which allows me to write code "naturally" = meaning by applying all the same "rules" and "guidelines" as i do when implementing "productive" code.
I'm planning to base it on xunit 2.0 (extensible test discovery!) (R# runner is currently lacking and i'm trying to get into contact with matt to see how i can help with that).
That should cut down implementation work and maintenance drastically as i won't have to maintain all the runner infrastructure.

If mspec wants to stay alive then it might be an option to use xunit 2.0 test discovery /-runners as well.

Maybe we should move this discussion somewhere else? New issue? Google groups?...

@danielmarbach
Copy link
Contributor

Bruno I tried that. The xunit discovery model makes assumptions about the things you can reflect on. Those assumptions are baked into the framework. You'd have to tweak redo a significant amount of code to achieve this

And by the way I also spiked a convention driven approach based on mspec which would work with xunit 2.0. if you need more details ping me

Am 24.02.2016 um 09:10 schrieb Bruno Juchli notifications@github.com:

I'm planning on starting to work on my own BDD/ATDD tool in the near future.
Why? Because i have some long-standing issues with mspec like not being able to access "this" and forcing me to use static variables all over (==> driver for test leakage). I want to have a spec-test suite which allows me to write code "naturally" = meaning by applying all the same "rules" and "guidelines" as i do when implementing "productive" code.
I'm planning to base it on xunit 2.0 (extensible test discovery!) (R# runner is currently lacking and i'm trying to get into contact with matt to see how i can help with that).
That should cut down implementation work and maintenance drastically as i won't have to maintain all the runner infrastructure.

If mspec wants to stay alive then it might be an option to use xunit 2.0 test discovery /-runners as well.


Reply to this email directly or view it on GitHub.

@BrunoJuchli
Copy link
Contributor

@danielmarbach
yeah i read your blog post a while ago and i think we had a short discussion about it, too. If you've got more information than what's present in the blog then i'm very happy to hear about it :-)

One can modify xunit 2.0 test discovery by placing an assembly-attribute on the test assembly.
Downside: makes xunit 2.0 and "mspec" (or whatever else) tests coexisting in the same assembly complicated. I've made a note to upload my spike to github.

Currently the xunit resharper runner supports running xunit 2.0 tests but it's still based on xunit 1 test-discovery so the assembly-attribute is not taken into consideration. The console runner though works.

@NameOfTheDragon
Copy link
Contributor

It’s a popular governance model, all the best OSS projects are doing it these days… ;-)
http://oss-watch.ac.uk/resources/benevolentdictatorgovernancemodel

Best regards,
Tim Long

From: Jan Fellien [mailto:notifications@github.com]
Sent: Wednesday, February 24, 2016 7:43 AM
To: machine/machine.specifications machine.specifications@noreply.github.com
Cc: Tim Long Tim@tigranetworks.co.uk
Subject: Re: [machine.specifications] You get a warning regarding ShouldBeOfType (#271)

@NameOfTheDragonhttps://github.com/NameOfTheDragon ‘benevolent dictator’ sounds good, but mostly I have problems with dictators ;-)

@machine/team-machinehttps://github.com/orgs/machine/teams/team-machine currently I'm only the contributor of mspec-light. But it seems so @danielmarbachhttps://github.com/danielmarbach thougth I'll take the helm. Oh no.. this ist not my intention. MSpec is a community driven project which is in the near of ending, I guess. So if we don't want that MSpec dies, we have to reorganize us.

Any Ideas @allhttps://github.com/all?


Reply to this email directly or view it on GitHubhttps://github.com//pull/271#issuecomment-188128424.

@drauch
Copy link
Contributor

drauch commented Feb 25, 2016

@BrunoJuchli : Are you sure about writing another framework? I personally don't think one-more-framework is going to solve all our problems. If you are interested in overcoming the downsides of MSpec and/or providing R# support for an existing framework get in contact with https://github.com/matkoch/TestFx . TestFx is two things: a test framework on which you can specify your own DSL while having out-of-the-box R# / TeamCity / etc. support + a sample DSL which overcomes MSpec's "static problem" (which is imo a huge downside in some situations).

I'd love to see MSpec living on, so I'm PRO Tim Long for ‘benevolent dictator’. Let's try. If it doesn't work out it can't possible be any worse than the current situation. Although I'm not sure that some dictator without time for design/coding/reviews is going to have much impact in the long run.

BR D.R.

@DerAlbertCom
Copy link

@danielmarbach with the new expression body functions and properties it maybe a good enough syntax for xunit possible, NUnit.Specifications does not work in NUnit 3, because they changed the behavior of theire api. but this is all off topic here in that issue ;)

@drauch
Copy link
Contributor

drauch commented Feb 25, 2016

I tried some new styles with the new C# method expressions in a very simple test framework, however, it is not enough. No void expressions allowed, too much bloat. Unfortunately no new possibilities.

@matkoch
Copy link

matkoch commented Mar 1, 2016

Can't help myself, but I really need to address this again: #286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants