New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
You get a warning regarding ShouldBeOfType #271
Conversation
In the warning the issue #171 is mentioned.
Updated documentation to reflect that ShouldBeOfType is now deprecated and ShouldBeOfExactType should be used. Thanks to NameOfTheDragon.
@wallymathieu thank you, i've integrated the PR. @machine/team-machine Thank you all for contributing to open source :-) |
I’m currently trying to find out who is at the helm. MSpec is too good to let it fade into obscurity and while I can’t dedicate much (or any) time to contributing code, I would be more than happy to take on the role of ‘benevolent dictator’ if that is needed to keep the project alive. Best regards, From: Bruno Juchli [mailto:notifications@github.com] — |
@NameOfTheDragon ‘benevolent dictator’ sounds good, but mostly I have problems with dictators ;-) @machine/team-machine currently I'm only the contributor of mspec-light. But it seems so @danielmarbach thougth I'll take the helm. Oh no.. this ist not my intention. MSpec is a community driven project which is in the near of ending, I guess. So if we don't want that MSpec dies, we have to reorganize us. Any Ideas @ALL? |
I'm planning on starting to work on my own BDD/ATDD tool in the near future. If mspec wants to stay alive then it might be an option to use xunit 2.0 test discovery /-runners as well. Maybe we should move this discussion somewhere else? New issue? Google groups?... |
Bruno I tried that. The xunit discovery model makes assumptions about the things you can reflect on. Those assumptions are baked into the framework. You'd have to tweak redo a significant amount of code to achieve this And by the way I also spiked a convention driven approach based on mspec which would work with xunit 2.0. if you need more details ping me
|
@danielmarbach One can modify xunit 2.0 test discovery by placing an assembly-attribute on the test assembly. Currently the xunit resharper runner supports running xunit 2.0 tests but it's still based on xunit 1 test-discovery so the assembly-attribute is not taken into consideration. The console runner though works. |
It’s a popular governance model, all the best OSS projects are doing it these days… ;-) Best regards, From: Jan Fellien [mailto:notifications@github.com] @NameOfTheDragonhttps://github.com/NameOfTheDragon ‘benevolent dictator’ sounds good, but mostly I have problems with dictators ;-) @machine/team-machinehttps://github.com/orgs/machine/teams/team-machine currently I'm only the contributor of mspec-light. But it seems so @danielmarbachhttps://github.com/danielmarbach thougth I'll take the helm. Oh no.. this ist not my intention. MSpec is a community driven project which is in the near of ending, I guess. So if we don't want that MSpec dies, we have to reorganize us. Any Ideas @allhttps://github.com/all? — |
@BrunoJuchli : Are you sure about writing another framework? I personally don't think one-more-framework is going to solve all our problems. If you are interested in overcoming the downsides of MSpec and/or providing R# support for an existing framework get in contact with https://github.com/matkoch/TestFx . TestFx is two things: a test framework on which you can specify your own DSL while having out-of-the-box R# / TeamCity / etc. support + a sample DSL which overcomes MSpec's "static problem" (which is imo a huge downside in some situations). I'd love to see MSpec living on, so I'm PRO Tim Long for ‘benevolent dictator’. Let's try. If it doesn't work out it can't possible be any worse than the current situation. Although I'm not sure that some dictator without time for design/coding/reviews is going to have much impact in the long run. BR D.R. |
@danielmarbach with the new expression body functions and properties it maybe a good enough syntax for xunit possible, NUnit.Specifications does not work in NUnit 3, because they changed the behavior of theire api. but this is all off topic here in that issue ;) |
I tried some new styles with the new C# method expressions in a very simple test framework, however, it is not enough. No void expressions allowed, too much bloat. Unfortunately no new possibilities. |
Can't help myself, but I really need to address this again: #286 |
In the warning the issue #171 is mentioned.