-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize dispatcher #342
base: main
Are you sure you want to change the base?
optimize dispatcher #342
Conversation
pkg/types/task/context.go
Outdated
) | ||
|
||
type ( | ||
CtxDispatcher struct{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private
types.WithTaskWorkerContext(types.MustTaskWorkerFromContext(parent)), | ||
types.WithTaskBoardContext(types.MustTaskBoardFromContext(parent)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't need.
types.WithMqttBrokerContext(types.MustMqttBrokerFromContext(parent)), | ||
)(context.Background()) | ||
|
||
ctx = task.WithDispatcher(parent, job.NewDispatcher(parent)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could it be integrated above?
No description provided.