Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolkit): toolkit improve #484

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

saitofun
Copy link
Collaborator

No description provided.

@saitofun saitofun marked this pull request as draft April 26, 2023 22:05
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 82.61% and project coverage change: +3.10 🎉

Comparison is base (7bfa38c) 56.38% compared to head (baaba72) 59.48%.

❗ Current head baaba72 differs from pull request most recent head 0c99a48. Consider uploading reports for the commit 0c99a48 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #484      +/-   ##
==========================================
+ Coverage   56.38%   59.48%   +3.10%     
==========================================
  Files         257      293      +36     
  Lines       20098    23023    +2925     
==========================================
+ Hits        11332    13695    +2363     
- Misses       8250     8726     +476     
- Partials      516      602      +86     
Impacted Files Coverage Δ
pkg/depends/gen/codegen/gen_impls.go 79.09% <0.00%> (-1.10%) ⬇️
pkg/depends/gen/codegen/gen_utils.go 39.58% <ø> (ø)
pkg/depends/kit/enumgen/enum.go 98.65% <ø> (-0.03%) ⬇️
.../depends/kit/httptransport/httpx/httpx_response.go 0.00% <ø> (ø)
pkg/depends/kit/modelgen/model.go 93.75% <ø> (-0.07%) ⬇️
pkg/depends/kit/statusxgen/generator.go 97.81% <ø> (-0.07%) ⬇️
pkg/depends/x/pkgx/pkgx_util.go 44.44% <0.00%> (-8.39%) ⬇️
pkg/depends/gen/codegen/gen_basic.go 77.84% <21.42%> (-0.59%) ⬇️
pkg/depends/gen/cmd/toolkit/cmd/gen_client.go 37.50% <37.50%> (ø)
pkg/depends/gen/cmd/toolkit/cmd/gen_openapi.go 41.17% <41.17%> (ø)
... and 37 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 33 Code Smells

No Coverage information No Coverage information
12.2% 12.2% Duplication

@saitofun saitofun force-pushed the iss/feat/toolkit-improve branch 2 times, most recently from 419f4db to baaba72 Compare July 5, 2023 10:13
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 33 Code Smells

No Coverage information No Coverage information
12.2% 12.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant