This repository has been archived by the owner on Mar 6, 2020. It is now read-only.
Fix source of memory leak in halcmd_main #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service_uuid char * is strdup() from the ini file entry string but this is not freed anywhere. Add cleanup() function to test and free where appropriate. Call this function before returns. Output from valgrind before amendments ==21671== LEAK SUMMARY: ==21671== definitely lost: 37 bytes in 1 blocks ==21671== indirectly lost: 0 bytes in 0 blocks ==21671== possibly lost: 12,657 bytes in 203 blocks ==21671== still reachable: 76,524 bytes in 413 blocks Output after amendments ==23009== LEAK SUMMARY: ==23009== definitely lost: 0 bytes in 0 blocks ==23009== indirectly lost: 0 bytes in 0 blocks ==23009== possibly lost: 12,657 bytes in 203 blocks ==23009== still reachable: 76,524 bytes in 413 blocks Signed-off-by: Mick <arceye@mgware.co.uk>
|
Unfortunately this is not the memory leak causing #1123 (comment) I found it whilst looking for that leak, this one has been around for a long time I think. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service_uuid char * is strdup() from the ini file entry string
but this is not freed anywhere.
Add cleanup() function to test and free where appropriate.
Call this function before returns.
Output from valgrind before amendments
==21671== LEAK SUMMARY:
==21671== definitely lost: 37 bytes in 1 blocks
==21671== indirectly lost: 0 bytes in 0 blocks
==21671== possibly lost: 12,657 bytes in 203 blocks
==21671== still reachable: 76,524 bytes in 413 blocks
Output after amendments
==23009== LEAK SUMMARY:
==23009== definitely lost: 0 bytes in 0 blocks
==23009== indirectly lost: 0 bytes in 0 blocks
==23009== possibly lost: 12,657 bytes in 203 blocks
==23009== still reachable: 76,524 bytes in 413 blocks
Signed-off-by: Mick arceye@mgware.co.uk