Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support #2

Closed
bsergean opened this issue Oct 5, 2018 · 1 comment
Closed

Windows support #2

bsergean opened this issue Oct 5, 2018 · 1 comment

Comments

@bsergean
Copy link
Collaborator

bsergean commented Oct 5, 2018

We should support windows.
@bsergean
Copy link
Collaborator Author

Fixed in 1680575

@AlexandreK38 AlexandreK38 mentioned this issue May 14, 2019
Closed
bsergean added a commit that referenced this issue May 17, 2019
@bsergean
Fix Address Sanitizer heap-buffer-overflow in WebSocketHandshakeKeyGe…
720d559 
…n::generate

=================================================================
==5077==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6070000077e0 at pc 0x00010ba18c54 bp 0x70000dd45b10 sp 0x70000dd45b08
READ of size 1 at 0x6070000077e0 thread T12
    #0 0x10ba18c53 in WebSocketHandshakeKeyGen::generate(char const*, char*) libwshandshake.hpp:113
    #1 0x10ba2065a in ix::WebSocketHandshake::serverHandshake(int, int) IXWebSocketHandshake.cpp:356
    #2 0x10b9c4952 in ix::WebSocketTransport::connectToSocket(int, int) IXWebSocketTransport.cpp:190
    #3 0x10b97e4c2 in ix::WebSocket::connectToSocket(int, int) IXWebSocket.cpp:193
bsergean added a commit that referenced this issue Feb 12, 2020
@bsergean
Fix Address Sanitizer heap-buffer-overflow in WebSocketHandshakeKeyGe…
6160877 
…n::generate

=================================================================
==5077==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x6070000077e0 at pc 0x00010ba18c54 bp 0x70000dd45b10 sp 0x70000dd45b08
READ of size 1 at 0x6070000077e0 thread T12
    #0 0x10ba18c53 in WebSocketHandshakeKeyGen::generate(char const*, char*) libwshandshake.hpp:113
    #1 0x10ba2065a in ix::WebSocketHandshake::serverHandshake(int, int) IXWebSocketHandshake.cpp:356
    #2 0x10b9c4952 in ix::WebSocketTransport::connectToSocket(int, int) IXWebSocketTransport.cpp:190
    #3 0x10b97e4c2 in ix::WebSocket::connectToSocket(int, int) IXWebSocket.cpp:193
martonp96 added a commit to martonp96/IXWebSocket that referenced this issue Dec 20, 2020
@martonp96
attempt machinezone#2
c3821a0
@zhayka52 zhayka52 mentioned this issue Feb 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsergean