-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close description can be un-initialized at time #33
Comments
I'll take a look when I have time but if you have an idea for a fix please go ahead :) |
ps: I should say that I am not positive that it is a regression, but it is still a bug. |
I had a look and created a PR to fix this, but in fact this was nothing to do with the 935e679
All of this should be fixed in PR #34 |
So is the issue fixed as you wanted with last PR? |
|
I think that the next step here is to add the ability to specify a reason and a code when calling websocket.close, but that might be very easy. |
Just 2 parameters to add; you can if you want to :) |
Doing it now ... :)
… On Apr 18, 2019, at 10:12 AM, Kumamon38 ***@***.***> wrote:
Just 2 parameters to add; you can if you want to :)
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#33 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC2O6UIIA6G54ZGFRCJ66KLPRCTXNANCNFSM4HGYRNRQ>.
|
We can see this easily by running continuously
make ws_test
. In that run below it it set to Normal closure / but at other times it is set to '%'.@Dimon4eg + @Kumamon38 / This is likely a regression of 935e679
I think this is why I was only setting the close reason only once in a weird way, like the first time it gets sets in one of the callbacks.
another run
The text was updated successfully, but these errors were encountered: