utils/rawTimeout: Use clearTimeout() instead of clearInterval()
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing tests that fake time with `lolex` it complains: > Cannot clear timer: timer created with setTimeout() but cleared with clearInterval() There is no clear reason for using `clearInterval()` here for something that was created with `setTimeout()`. Using `clearTimeout()` instead seems more straight forward and would solve this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing tests that fake time with
lolexit complains:There is no clear reason for using
clearInterval()here for something that was created withsetTimeout(). UsingclearTimeout()instead seems more straight forward and would solve this issue.Unrelated: I noticed that
rawTimeout()is undocumented and not exported from the top-level file. Is there a reason for that? Is it not supposed to be used?