Ensure tasks are assigned to a container #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with service injection inside of encapsulated tasks on Ember 3.13+ by ensuring tasks that are children of other tasks are assigned a container to use for service injection.
Turbo87
reviewed
Sep 16, 2019
| @@ -7,18 +7,17 @@ export default Controller.extend({ | |||
|
|
|||
| myTask: task({ | |||
| fun: service(), | |||
| perform: function * () { | |||
| *perform() { | |||
There was a problem hiding this comment.
unrelated to the fix but cleaner. Didn't feel like it warranted omission 😛
|
@maxfierke is the test suite failing without this patch? otherwise it might make sense to create a test for it that verifies that this works correctly with both old and new Ember versions |
|
@Turbo87 yeah, the build fails on master for |
This was referenced Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with service injection inside
of encapsulated tasks on Ember 3.13+ by ensuring
tasks that are children of other tasks are
assigned a container to use for service injection.