Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace cancelOn with cancelAll in route-tasks #376

Merged
merged 1 commit into from Oct 6, 2020

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Oct 2, 2020

Small docs change. PR #317 changed the detail-route.js snippet but didn't update the corresponding section of the docs. This is that snippet:

https://github.com/machty/ember-concurrency/blob/2be69e87280e7302c0ccfbb21b3884bc04db376f/tests/dummy/app/docs/examples/route-tasks/detail/route.js#L5-L34

Copy link
Collaborator

@maxfierke maxfierke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@maxfierke maxfierke merged commit 152063e into machty:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants