Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly import from private task-instance #411

Merged
merged 1 commit into from
Mar 4, 2021

Conversation

mydea
Copy link
Contributor

@mydea mydea commented Mar 4, 2021

In my typescript app I noticed these warnings:

WARNING in ./node_modules/ember-concurrency/-task-instance.js 4:15-27
"export 'default' (imported as 'TaskInstance') was not found in './-private/task-instance'
@ ./assets/my-app.js
    
WARNING in ./node_modules/ember-concurrency/index.js 11:0-378
"export 'default' (reexported as 'TaskInstance') was not found in './-private/task-instance'
@ ./node_modules/ember-power-select/components/power-select.js
@ ./assets/my-app.js

So I went and looked, and it seems they were incorrectly importing the default instead of named export. I guess this isn't used anywhere, as otherwise it should have broken (?) somehow. I fixed the imports here.

Copy link
Collaborator

@maxfierke maxfierke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: nice! yeah, that export is just for consumers that might have been importing TaskInstance via a private module import (naughty, naughty) from 1.x, so not a huge deal, but good to fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants