Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure quotes around bound attribute values #302

Merged
merged 4 commits into from
Dec 20, 2017
Merged

Ensure quotes around bound attribute values #302

merged 4 commits into from
Dec 20, 2017

Conversation

quaelin
Copy link
Contributor

@quaelin quaelin commented Dec 18, 2017

@thec0keman
Copy link
Collaborator

Thanks for submitting!

I think we need to blacklist these changes for dom events. For example, this is invalid syntax for Ember:
<select onchange=\"{{action (mut vehicle) value="target.value"}}\"></select>

This is because the action helper generates a closure that is assigned to the dom event. I'm pretty sure events would be the only dom elements that shouldn't have strings.

@quaelin
Copy link
Contributor Author

quaelin commented Dec 18, 2017

Ok. Do you think it would work to blacklist these changes for any attribute beginning with "on"? That seems easier to maintain than an explicit list like onchange, onfocus, onblur, onmouseover....

@thec0keman
Copy link
Collaborator

That seems to be valid

@quaelin
Copy link
Contributor Author

quaelin commented Dec 19, 2017

@thec0keman ok, made that change 👍

@thec0keman thec0keman merged commit 0cdf05c into machty:master Dec 20, 2017
@quaelin
Copy link
Contributor Author

quaelin commented Dec 20, 2017

Thanks for merging, @thec0keman. Any thoughts on when you might plan to publish a new version to npm?

@quaelin quaelin deleted the quote-attributes branch December 21, 2017 17:24
@thec0keman
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants