Set runner's information to the output much earlier #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machulav
added
bug
mmoriani
pushed a commit
to ottimis/ec2-github-runner
that referenced
this pull request
Feb 15, 2024
* Set runner's information to the output earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the GitHub Action workflow is canceled during the execution of the "Start self-hosted EC2 runner" job, the final job, "Stop self-hosted EC2 runner" failed as the input was provided only at the end of the first job. Though, the EC2 runner data available already in the first seconds of the first job execution. The rest of the time, the script waits for the runner to be registered as a self-hosted runner in GitHub actions.
These changes make the output available earlier, right after the EC2 runner data is available. In this way, the EC2 runner can be properly terminated even if the GitHub Actions workflow is canceled during the execution of the "Start self-hosted EC2 runner" job.
Related to issue #7