Allow pat tokens #196
Open
Allow pat tokens #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks, considering more organizations are choosing to force the use of the new fine-grained access tokens, I took a stab at implementing the feature. It's working well on our end. Lmk what you think.
Basically I'm solving this with a new var:
github-token-type. If this value is not specified, orclassic, then we'll use the old--tokenarg. If the user passesfine-grained, then we will use the--patarg that allows the use of fine-grained tokens.Note that this change also includes the work done in #127. Simply because we needed both fixes. However I'm happy to leave that out and allow discussion to continue over there if that's preferable.
Fixes #160, builds upon #127