Increase retry interval, add quiet period, add info logging #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, it doesn't look like the PR package automation is working (probably because I am working from a fork - which I typically do for most OSS contributions). Was there something wrong with the dist being updated after merging to main? That seemed to work nicely. |
machulav
added
bug
|
@hajapy Many thanks for the improvement!
It seems that it doesn't work properly with forks. I will try to figure it out and fix it. |
mmoriani
pushed a commit
to ottimis/ec2-github-runner
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
In my runs I am seeing about 1 minute between instanceStarted and runner registered, so I implemented just a short quiet period of 30s, and made the time delay 10s. This could be further tuned, or exposed as config parameters to let people tune it to their use case.