Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPO3 9 compatibility #90

Closed
msollmann opened this issue Jan 29, 2019 · 7 comments
Closed

TYPO3 9 compatibility #90

msollmann opened this issue Jan 29, 2019 · 7 comments

Comments

@msollmann
Copy link

Are you planning a version for TYPO3 9? Would be great!

@derhansen
Copy link
Collaborator

Yes, @machwatt is working on a version for TYPO3 9

@msollmann
Copy link
Author

Do you know when the extension will be ready, approximately?

@machwatt
Copy link
Owner

I starting working on it today and hopefully find the time to finish it this week.

@machwatt
Copy link
Owner

@msollmann So i filed a release 1.5.0 with support for v9 – should work as intented.
The pagination template has changed a little.

Releasing to TER later on.

@msollmann
Copy link
Author

Yes, it works! Thank you very much!

@Patta
Copy link
Contributor

Patta commented Mar 29, 2019

There are some problems in my environment:

  • the css file is not included
    this example constant does not work: plugin.tx_sffilecollectiongallery.settings.cssFile = EXT:sitepackage/Resources/Public/Css/Extensions/gallery.css
  • the paginator is displayed even if there is only one page, previously it was hidden (templates are adopted like in 2c4874c)
  • the paginator does not accept the markup from template/paginate/index.html
    this example setup does not work: plugin.tx_sffilecollectiongallery.view.widget.SKYFILLERS\SfFilecollectionGallery\ViewHelpers\PaginateViewHelper.templateRootPath = EXT:sitepackage/Resources/Private/Templates/Extensions/SfFilecollectionGallery/

resolved with #92 and #93

@machwatt
Copy link
Owner

machwatt commented Mar 6, 2020

I consider this as closed now – thanks for your support there Patta.

@machwatt machwatt closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants