Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for host-shared folders using virtio-9p #97

Closed
wants to merge 14 commits into from

Conversation

stv0g
Copy link

@stv0g stv0g commented Apr 3, 2016

Please consider this PR a WiP.

@jceel has implemented support for host-shared directories / mounts like requested in #45 and #70.

There are a few points we still need to tackle.
And the best way to do this is by getting some feedback. Especially from @mist64 :-)

  • Are you fine with introducing new dependencies like jceel's lib9p?
  • How do you want to track dependencies:
    • git submodule?
    • pkg-config
    • ??
  • Allow building without virtio-9p support
  • lib9p is not based on on Plan 9 lib9p nor libixp. We should clarify that in the README of jceel's lib9p.

@c4milo
Copy link
Member

c4milo commented Apr 9, 2016

I'm all for getting lib9p introduced into xhyve. Any thoughts on this @xez?

@stv0g
Copy link
Author

stv0g commented Apr 11, 2016

@c4milo What do you mean by 'introduced'?

Using a git-submodule? Or by copy&paste the code?
Or even without all?

@c4milo
Copy link
Member

c4milo commented Apr 11, 2016

Whatever method is more convenient to update from upstream.

On Mon, Apr 11, 2016 at 2:55 PM Steffen Vogel notifications@github.com
wrote:

@c4milo https://github.com/c4milo What do you mean by 'introduced'?

Using a git-submodule? Or by copy&paste the code?
Or even without all?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#97 (comment)

@foxx
Copy link

foxx commented Sep 7, 2016

Any update on this?

@stv0g
Copy link
Author

stv0g commented Sep 16, 2016

I lost the overview which repo is now the official one.
I don't know where its merged or not.

Copy link

@bms bms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely needs to be exercised :-) next time I'm around a Mac, I may try this directly with a Linux guest.

@smiren
Copy link

smiren commented Oct 12, 2016

What news?

@mfojtik
Copy link

mfojtik commented Sep 18, 2017

Seems like this needs a rebase as this won't build on latest OSX :-(

@dinamic
Copy link

dinamic commented Jan 21, 2019

Guys, it will be awesome if we could have this functionality baked in. Is there any progress?

@stv0g could you rebase?

@jeremyhu
Copy link
Member

@jasnee Was looking at this a couple weeks ago for me. There were some comments he wanted to pass along before we merge this in. James, could you please provide your feedback here?

@stv0g
Copy link
Author

stv0g commented May 1, 2019

Sorry. I dont have any interest anymore in getting this merged.

If there is anybody else, please feel free to open a new PR with my changes rebased..

@stv0g stv0g closed this May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants