New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't store `JsValue` in `ListenerProduct` #75

Merged

maciejhirsz merged 4 commits into master from no-jsvalue-closures

Apr 15, 2023

Owner

maciejhirsz commented Apr 15, 2023 •

edited

No need to store the JsValue for a closure, it's fine to just pass it into the compiled JS code by value.
No need to update bound event listeners if the closure they are created from is zero-sized.

This results in a minor reduction in the Wasm file (TodoMVC goes from 35173 bytes to 34986 bytes, uncompressed).

maciejhirsz added 4 commits

April 15, 2023 17:12


          Remove JsValue from ListenerProduct

5a0c5e0


          Use NonNull pointers in ListenerProduct

ba866ce


          Version bump

fb3727f


          Don't update zero-sized event listeners

dfa022c

maciejhirsz merged commit 39858b3 into master

3 checks passed

maciejhirsz deleted the no-jsvalue-closures branch

April 15, 2023 16:58

maciejhirsz mentioned this pull request

1.0 tracking issue #74

Open

10 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment