Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): automatically build handbook #293

Merged
merged 5 commits into from
Apr 13, 2023
Merged

Conversation

jeertmans
Copy link
Collaborator

Hello, this small PR to propose automating the build and deploying of Logos handbook.

This will surely help people see new versions of the handbook. Currently, this deploys from the book branch, but in the end it should use the master branch.

This PR also rebases onto the master branch.

A small setup is required from your site to allow deploying a GitHub page from a workflow from the book branch.

@jeertmans jeertmans changed the title chore(ci): automatically build chore(ci): automatically build handbook Apr 13, 2023
@maciejhirsz
Copy link
Owner

small PR

image

😅

It's a bit hard to review, I'll try to rebase the book branch when I get a moment.

@jeertmans
Copy link
Collaborator Author

Rebasing your book branch onto master should solve this, because this PR is pretty minimalist, and aims to pave the way for the future of the handbook.

@maciejhirsz maciejhirsz merged commit dcfd3d7 into maciejhirsz:book Apr 13, 2023
2 checks passed
@maciejhirsz
Copy link
Owner

Diff got a bit wonky, but this works, cheers!

@jeertmans
Copy link
Collaborator Author

Nice! I will soon start to work a bit on the handbook. Do you prefer that I do PRs on your book branch or on the master one?

@maciejhirsz
Copy link
Owner

I'd say let's keep it in the book for now until content is a functional MVP.

jeertmans added a commit to jeertmans/logos that referenced this pull request Jun 23, 2023
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <hello@maciej.codes>
jeertmans added a commit that referenced this pull request Jun 23, 2023
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <hello@maciej.codes>
jeertmans added a commit that referenced this pull request Jun 25, 2023
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <hello@maciej.codes>
jeertmans added a commit that referenced this pull request Jun 25, 2023
* Initial commit for the Logos Handboook

* A bit more adds to the book

* chore(ci): setup automated CI for book

* chore(ci): update branches

* fix(ci): remove extra needs

---------

Co-authored-by: Maciej Hirsz <hello@maciej.codes>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants