Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Source test for GAT Slice #334

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

kmicklas
Copy link
Contributor

#332 and #333 weren't compatible, so master is currently broken. Sorry I forgot to warn about that @jeertmans!

@jeertmans
Copy link
Collaborator

Oh nice catch, that’s actually my bad I did not rebase the branch!

I see that benchmarks are failing, maybe it is worth updating the lock file?

@kmicklas
Copy link
Contributor Author

It looks like a spurious download error?

@jeertmans
Copy link
Collaborator

Indeed, I read the error messages too fast 😅

Looks perfect!

@jeertmans jeertmans merged commit 291a624 into maciejhirsz:master Aug 17, 2023
16 checks passed
@kmicklas kmicklas deleted the source-fixes branch August 17, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants