Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-28: add support for multiple property injection #29

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

rfelgent
Copy link

@rfelgent rfelgent commented Mar 5, 2024

hi @maciejwalkowiak ,

here is the pull request for #28.

Please let me know what else I can do for this pull request to be accepted.

@rfelgent rfelgent changed the title GH-28: add support for multiple property binding GH-28: add support for multiple property binding injection Mar 5, 2024
@rfelgent rfelgent changed the title GH-28: add support for multiple property binding injection GH-28: add support for multiple property injection Mar 5, 2024
Copy link
Owner

@maciejwalkowiak maciejwalkowiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some polishing, but seems I can't push to your branch, so take a look at this commit: 4a85af0

Unless there's something that i've missed, feel free to cherry-pick it and update your branch.

Also please update a readme, like a line or two that you can also set multiple properties and why would you want to do that.

Once its there, I'll merge and trigger a new release.

Thanks for contribution!

@rfelgent
Copy link
Author

rfelgent commented Apr 1, 2024

Hi @maciejwalkowiak ,

I added some hints about the multiple property injection feature. Please have look at the README.md.
While updating the README.md, 2 questions came into my mind:

  • should we rename the attribute from property to properties (hard migration with breaking changes) or
  • should we add another attribute called properties and it can co-exists with property (soft migration, no breaking changes)

Greetings

PS: I am not used to work with forks. I created another PR for updating the README.md #31

*/
String property() default "";
String[] property() default "";
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current implementation is fully backward compatible.

But its readability is not as good as it could be when renaming the attribute to properties, is it ?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Add properties and mark property as deprecated. For the time being we will support both, later the property will be removed.

@maciejwalkowiak
Copy link
Owner

Thanks @rfelgent! Thanks for updating readme, don't worry it is in another branch, i'll put it into main all together when we have this PR ready.

@rfelgent
Copy link
Author

rfelgent commented Apr 4, 2024

Hi @maciejwalkowiak ,

I renamed/refactored the attributes property and properties of ConfigureWireMock.
Please have a look at https://github.com/maciejwalkowiak/wiremock-spring-boot/pull/32/files

@rfelgent
Copy link
Author

Hi @maciejwalkowiak ,

please let me know what else I can do for this merge request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants