Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix so iReSign can re-sign the frameworks inside an app bundle #46

Merged
merged 3 commits into from Aug 4, 2015

Conversation

adzellman
Copy link
Contributor

These changes allow iReSign to sign frameworks inside an app bundle. Without this change, iReSign says the re-signing succeeds, but it won't install if there are frameworks in the app.

@jamhung
Copy link

jamhung commented Jun 5, 2015

I second @Deanzou 's comment. Would love to see this fix merged into master! Is there a reason for the hold up?

@chrisvire
Copy link
Contributor

Looking at the PR, it looks like there are more accidental changes than just handling resigning of frameworks. I am going to try to make a cleaner PR.

@adzellman
Copy link
Contributor Author

Well, it wasn't exactly accidental. It was an intentional minor
rearchitecture.
On Mon, Aug 3, 2015 at 7:22 PM Chris Hubbard notifications@github.com
wrote:

Looking at the PR, it looks like there are more accidental changes than
just handling resigning of frameworks. I am going to try to make a cleaner
PR.


Reply to this email directly or view it on GitHub
#46 (comment).

@maciekish maciekish merged commit e073f20 into maciekish:master Aug 4, 2015
maciekish added a commit that referenced this pull request Aug 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants