Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed field name from profile_pic to picture #29

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

catoaune
Copy link
Contributor

Got an error using profile_pic "(#100) Tried accessing nonexisting field (profile_pic) on node type (User)" while picture is working

Got an error using profile_pic "(#100) Tried accessing nonexisting field (profile_pic) on node type (User)" while picture is working
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.875% when pulling 9a9c465 on catoaune:catoaune-patch-1 into 71a3a43 on maciekmm:master.

@maciekmm maciekmm merged commit 64a3d3f into maciekmm:master Jun 20, 2017
@maciekmm
Copy link
Owner

@catoaune Thanks for your contribution.

@maciekmm
Copy link
Owner

@catoaune I just tested this because something seemed wrong (the messenger platform documentation mentions profile_pic) and it indeed is profile_pic. I reverted the commit. Could you provide more information of the context of this error?

@catoaune
Copy link
Contributor Author

I am sorry for providing a bad patch.
I was working on messenger for Workplace by Facebook and got an error when using profile_pic, while picture did work.
I did try to search in the regular Facebook messenger developer documentation to see if profile_pic had been replaced by picture in recent API versions. I found this document - https://developers.facebook.com/docs/graph-api/reference/user - and based on this
"picture The person's profile picture"
and the fact that it did work with picture in Workplace, I assumed it had changed also in the regular messenger API. Of course I should not just assume but also test, and I am sorry for that.

@maciekmm
Copy link
Owner

maciekmm commented Jul 1, 2017

@catoaune No worries :)
Is this library of any help when developing for 'messenger for Workplace'? If so maybe adding a flag to support that product would be a good idea? :>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants