Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Button Templates #31

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

seenickcode
Copy link

Ability to send Button Templates without receiving an error from Facebook, as this feature never worked for the latest Facebook Send API. Button templates basically require a 'buttons' field rather than an 'elements' field.

…book. Button templates require a 'buttons' fields in the payload, not the standard 'elements' field.
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 91.367% when pulling 1752100 on seenickcode:master into b41e939 on maciekmm:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.7%) to 87.185% when pulling a4cabab on seenickcode:master into b41e939 on maciekmm:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.7%) to 87.185% when pulling 0775478 on seenickcode:master into b41e939 on maciekmm:master.

@maciekmm
Copy link
Owner

maciekmm commented Jul 6, 2017

@seenickcode Thanks for your contribution, but unfortunately the code neither compiles nor it has required coverage. First of all, please fix import paths. When contributing to Go projects it's advised to clone the repository to the directory which path reflects the location of the mainstream repo, not the fork. That way, albeit not importable from the outside world, the code works locally.

@seenickcode
Copy link
Author

Does this article explain a recommendation properly? http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html if so I will follow it and re-submit.

@maciekmm
Copy link
Owner

maciekmm commented Aug 7, 2017

@seenickcode yes, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants