Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests are failing because of new pyright release. #847

Closed
janfb opened this issue Jun 12, 2023 · 3 comments · Fixed by #1045
Closed

tests are failing because of new pyright release. #847

janfb opened this issue Jun 12, 2023 · 3 comments · Fixed by #1045
Assignees
@Baschdl
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon karma Karma issues: potentially annoying but very important issues
Milestone
Hackathon and rel...

Comments

@janfb
Copy link
Contributor

janfb commented Jun 12, 2023

there seem to be new checks in the pyright release that lead to pyright failing in our workflow.

The latest commit on main was tested with pyright v1.1.304. the newest version is v1.1.313.
@janfb janfb added the bug Something isn't working label Jun 12, 2023
@janfb janfb self-assigned this Jun 12, 2023
This was referenced Jun 12, 2023
Merged
Merged
Merged
@janfb
Copy link
Contributor Author

janfb commented Jun 13, 2023

solution for now as proposed in #848 : pin pyright to last passing version and fix type issues before the next major release, or when changing to nflows.

@janfb janfb added the blocked Something is in the way of fixing this. Refer to it in the issue label Jun 13, 2023
@janfb janfb self-assigned this Feb 9, 2024
@janfb
Copy link
Contributor Author

janfb commented Feb 9, 2024

idea: change to ruff to handle type checking more flexibly: https://docs.astral.sh/ruff/

related to #928

@manuelgloeckler manuelgloeckler mentioned this issue Feb 20, 2024
Merged
@janfb
Copy link
Contributor Author

janfb commented Feb 27, 2024

update: ruff does not do type checking, so we do need pyright.

Task for the PR solving this issue:

  • change pyproject.toml to depend on most recent pyright version, i.e., remove the pin.
  • execute pyright sbi tests locally and fix the errors or comment in the PR if not fixable.

@janfb janfb added documentation Improvements or additions to documentation enhancement New feature or request hackathon and removed blocked Something is in the way of fixing this. Refer to it in the issue labels Feb 28, 2024
@janfb janfb removed their assignment Feb 28, 2024
@janfb janfb added this to the Hackathon 2024 milestone Feb 28, 2024
@janfb janfb added the karma Karma issues: potentially annoying but very important issues label Feb 28, 2024
@Baschdl Baschdl self-assigned this Mar 19, 2024
@Baschdl Baschdl mentioned this issue Mar 19, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Baschdl Baschdl

Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request hackathon karma Karma issues: potentially annoying but very important issues
Projects
None yet
Milestone
Hackathon and release 0.23
Development

Successfully merging a pull request may close this issue.

Use newest version of pyright, ignored a lot of errors, identified some bugs sbi-dev/sbi
2 participants
@Baschdl @janfb