Fixed a bug from CNRE #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janfb
reviewed
Mar 6, 2023
Yes, it will change the behavior of the algorithm. There was an extra (incorrect) K in the denominator. |
|
Thanks for the clarifications. Tests are failing due to |
|
Is it possible to rerun the test from github? I did black formatting but the test was canceled. |
|
Yes. Not sure this works for you as well, but for me there is a "re-run jobs" button in the top right corner. |
janfb
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug in the code that implements contrastive neural ratio estimation. I fixed that here.