Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve pairplot options #865

Merged
merged 3 commits into from
Aug 4, 2023
Merged

improve pairplot options #865

merged 3 commits into from
Aug 4, 2023

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Aug 1, 2023

closes #864

@janfb janfb added the enhancement New feature or request label Aug 1, 2023
@janfb janfb self-assigned this Aug 1, 2023
@janfb janfb force-pushed the fix-pairplot branch 3 times, most recently from 8363f91 to 40c0aa0 Compare August 1, 2023 16:23
@janfb janfb changed the title Fix pairplot improve pairplot options Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #865 (6787abf) into main (8769e25) will increase coverage by 0.96%.
Report is 3 commits behind head on main.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##             main     #865      +/-   ##
==========================================
+ Coverage   74.60%   75.56%   +0.96%     
==========================================
  Files          80       80              
  Lines        6242     6250       +8     
==========================================
+ Hits         4657     4723      +66     
+ Misses       1585     1527      -58     
Flag Coverage Δ
unittests 75.56% <73.91%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
sbi/analysis/tensorboard_output.py 86.25% <ø> (ø)
sbi/analysis/plot.py 70.63% <73.91%> (+14.19%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have very mixed feelings about the cross though -- I personally prefer the dot (simply because it looks better).

sbi/analysis/plot.py Show resolved Hide resolved
sbi/analysis/plot.py Show resolved Hide resolved
@janfb janfb force-pushed the fix-pairplot branch 3 times, most recently from 2c10c81 to 042188c Compare August 2, 2023 09:22
@janfb janfb merged commit 0e75b11 into main Aug 4, 2023
2 of 3 checks passed
@janfb janfb deleted the fix-pairplot branch August 4, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve pairplot default args
2 participants