Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message for service metadata import #52

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

masayoshi634
Copy link
Contributor

I fix error message.

@heleeen
Copy link
Contributor

heleeen commented Jul 9, 2021

Please fix test case 🙏

ExpectError: regexp.MustCompile("the ID must be in the form '<service name>:<namespace>'"),

@coveralls
Copy link

coveralls commented Jul 9, 2021

Pull Request Test Coverage Report for Build 1014360470

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.884%

Totals Coverage Status
Change from base Build 977657354: 0.0%
Covered Lines: 2301
Relevant Lines: 2375

💛 - Coveralls

@masayoshi634 masayoshi634 merged commit 468df9d into master Jul 12, 2021
@masayoshi634 masayoshi634 deleted the fix-error-message-for-service-metadata-import branch July 12, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants