Improve docker plugin #436
Conversation
|
I found |
Those metrics names are `IOPS`, but previously it was IO per Minute!
This reverts commit 09fc65a.
| @@ -37,7 +37,7 @@ var graphdef = map[string]mp.Graphs{ | |||
| }, | |||
| "docker.memory.#": { | |||
| Label: "Docker Memory", | |||
| Unit: "integer", | |||
| Unit: "bytes", | |||
There was a problem hiding this comment.
docker.memory.#.{cache,rss} are taken from cgroup memory.stat
https://www.kernel.org/doc/Documentation/cgroup-v1/memory.txt
memory.stat file includes following statistics
# per-memory cgroup local status
cache - # of bytes of page cache memory.
rss - # of bytes of anonymous and swap cache memory (includes
transparent hugepages).
There was a problem hiding this comment.
btw, in many Linux distributions these stats are always zero (but in Docker for Mac non-zero).
ref: https://docs.docker.com/engine/admin/runmetrics/#memory-metrics-memorystat
Therefore, many distros chose to not enable it by default.
| }, | ||
| }, | ||
| "docker.blkio.io_service_bytes.#": { | ||
| Label: "Docker BlkIO Bytes", | ||
| Unit: "integer", | ||
| Unit: "bytes", |
There was a problem hiding this comment.
https://www.kernel.org/doc/Documentation/cgroup-v1/blkio-controller.txt
- blkio.io_service_bytes
- Number of bytes transferred to/from the disk by the group. These
are further divided by the type of operation - read or write, sync
or async. First two fields specify the major and minor number of the
device, third field specifies the operation type and the fourth field
specifies the number of bytes.
| {Name: "write", Label: "Write", Diff: true, Stacked: true, Type: "uint64"}, | ||
| {Name: "sync", Label: "Sync", Diff: true, Stacked: true, Type: "uint64"}, | ||
| {Name: "async", Label: "Async", Diff: true, Stacked: true, Type: "uint64"}, | ||
| {Name: "read", Label: "Read", Diff: true, Stacked: true, Type: "uint64", Scale: (1.0 / 60.0)}, |
There was a problem hiding this comment.
https://www.kernel.org/doc/Documentation/cgroup-v1/blkio-controller.txt
- blkio.io_serviced
- Number of IOs (bio) issued to the disk by the group. These
are further divided by the type of operation - read or write, sync
or async. First two fields specify the major and minor number of the
device, third field specifies the operation type and the fourth field
specifies the number of IOs.
| @@ -55,17 +55,17 @@ var graphdef = map[string]mp.Graphs{ | |||
| }, | |||
There was a problem hiding this comment.
https://www.kernel.org/doc/Documentation/cgroup-v1/blkio-controller.txt
- blkio.io_queued
- Total number of requests queued up at any given instant for this
cgroup. This is further divided by the type of operation - read or
write, sync or async.
|
LGTM |
|
Thanks. |
Changed graph unit and scaled
blkio.io_servicedto get IOPS properly.