Log only if metrics generator take a long time

mackerelio · Jan 31, 2018 · 240bfab · 240bfab
1 parent 8de7130
commit 240bfab
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/agent/generator.go b/agent/generator.go
@@ -42,7 +42,9 @@ func generateValues(generators []metrics.Generator) []*metrics.ValuesCustomIdent
 
 				startedAt := time.Now()
 				values, err := g.Generate()
-				logger.Debugf("%T.Generate() finished in %d ms", g, (time.Now().Sub(startedAt) / time.Millisecond))
+				if seconds := (time.Now().Sub(startedAt) / time.Second); seconds > 120 {
+					logger.Warningf("%T.Generate() take a long time (%d seconds)", g, (time.Now().Sub(startedAt) / time.Second))
+				}
 				if err != nil {
 					logger.Errorf("Failed to generate value in %T (skip this metric): %s", g, err.Error())
 					return