Merge 8366bf8 into 1293e81

mackerelio · Mar 20, 2019 · 6181da5 · 6181da5
2 parents 1293e81 + 8366bf8
commit 6181da5
Showing 1 changed file with 42 additions and 7 deletions.
diff --git a/Makefile b/Makefile
@@ -1,28 +1,33 @@
 MACKEREL_AGENT_NAME ?= "mackerel-agent"
 MACKEREL_API_BASE ?= "https://api.mackerelio.com"
-VERSION = 0.59.1
-CURRENT_REVISION = $(shell git rev-parse --short HEAD)
-ARGS = "-conf=mackerel-agent.conf"
-BUILD_OS_TARGETS = "linux darwin freebsd windows netbsd"
+VERSION := 0.59.1
+CURRENT_REVISION := $(shell git rev-parse --short HEAD)
+ARGS := "-conf=mackerel-agent.conf"
+BUILD_OS_TARGETS := "linux darwin freebsd windows netbsd"
 
-BUILD_LDFLAGS = "\
+BUILD_LDFLAGS := "\
 	  -X main.version=$(VERSION) \
 	  -X main.gitcommit=$(CURRENT_REVISION) \
 	  -X github.com/mackerelio/mackerel-agent/config.agentName=$(MACKEREL_AGENT_NAME) \
 	  -X github.com/mackerelio/mackerel-agent/config.apibase=$(MACKEREL_API_BASE)"
 
+.PHONY: all
 all: clean test build
 
+.PHONY: test
 test: lint
 	go test -v -short $(TESTFLAGS) ./...
 
+.PHONY: build
 build: deps
 	go build -ldflags=$(BUILD_LDFLAGS) \
 	  -o build/$(MACKEREL_AGENT_NAME)
 
+.PHONY: run
 run: build
 	./build/$(MACKEREL_AGENT_NAME) $(ARGS)
 
+.PHONY: deps
 deps:
 	go get -d -v -t ./...
 	go get golang.org/x/lint/golint   \
@@ -31,14 +36,17 @@ deps:
 	  github.com/mattn/goveralls      \
 	  github.com/motemen/go-cli/gen
 
+.PHONY: lint
 lint: deps
 	go tool vet -all -printfuncs=Criticalf,Infof,Warningf,Debugf,Tracef .
 	_tools/go-linter $(BUILD_OS_TARGETS)
 
+.PHONY: convention
 convention:
 	go generate ./... && git diff --exit-code || \
 	  (echo 'please `go generate ./...` and commit them' && false)
 
+.PHONY: crossbuild
 crossbuild: deps
 	cp mackerel-agent.sample.conf mackerel-agent.conf
 	goxz -build-ldflags=$(BUILD_LDFLAGS) \
@@ -50,23 +58,30 @@ crossbuild: deps
 		-include=mackerel-agent.conf \
 		-n $(MACKEREL_AGENT_NAME) -o $(MACKEREL_AGENT_NAME)
 
+.PHONY: cover
 cover: deps
 	gotestcover -v -race -short -covermode=atomic -coverprofile=.profile.cov -parallelpackages=4 ./...
 
+.PHONY: crossbuild-package
 crossbuild-package:
 	mkdir -p ./build-linux-386 ./build-linux-amd64
 	GOOS=linux GOARCH=386 make build
 	mv build/$(MACKEREL_AGENT_NAME) build-linux-386/
 	GOOS=linux GOARCH=amd64 make build
 	mv build/$(MACKEREL_AGENT_NAME) build-linux-amd64/
 
+.PHONY: crossbuild-package-kcps
 crossbuild-package-kcps:
 	make crossbuild-package MACKEREL_AGENT_NAME=mackerel-agent-kcps MACKEREL_API_BASE=http://198.18.0.16
 
+.PHONY: crossbuild-package-stage
 crossbuild-package-stage:
 	make crossbuild-package MACKEREL_AGENT_NAME=mackerel-agent-stage MACKEREL_API_BASE=http://0.0.0.0
 
+.PHONY: rpm
 rpm: rpm-v1 rpm-v2
+
+.PHONY: rpm-v1
 rpm-v1: crossbuild-package
 	MACKEREL_AGENT_NAME=$(MACKEREL_AGENT_NAME) _tools/packaging/prepare-rpm-build.sh
 	docker run --rm -v "$(PWD)":/workspace -v "$(PWD)/rpmbuild":/rpmbuild astj/mackerel-rpm-builder:c5 \
@@ -79,6 +94,7 @@ rpm-v1: crossbuild-package
 	--define "_version ${VERSION}" --define "buildarch x86_64" \
 	-bb packaging/rpm-build/$(MACKEREL_AGENT_NAME).spec
 
+.PHONY: rpm-v2
 rpm-v2: crossbuild-package
 	BUILD_SYSTEMD=1 MACKEREL_AGENT_NAME=$(MACKEREL_AGENT_NAME) _tools/packaging/prepare-rpm-build.sh
 	docker run --rm -v "$(PWD)":/workspace -v "$(PWD)/rpmbuild":/rpmbuild astj/mackerel-rpm-builder:c7 \
@@ -91,17 +107,23 @@ rpm-v2: crossbuild-package
 	--define "_version ${VERSION}" --define "buildarch x86_64" --define "dist .amzn2" \
 	-bb packaging/rpm-build/$(MACKEREL_AGENT_NAME).spec
 
+.PHONY: deb
 deb: deb-v1 deb-v2
 
+.PHONY: deb-v1
 deb-v1: crossbuild-package
 	BUILD_DIRECTORY=build-linux-386 MACKEREL_AGENT_NAME=$(MACKEREL_AGENT_NAME) _tools/packaging/prepare-deb-build.sh
 	cd packaging/deb-build && debuild --no-tgz-check -uc -us
 
+.PHONY: deb-v2
 deb-v2: crossbuild-package
 	BUILD_DIRECTORY=build-linux-amd64 BUILD_SYSTEMD=1 MACKEREL_AGENT_NAME=$(MACKEREL_AGENT_NAME) _tools/packaging/prepare-deb-build.sh
 	cd packaging/deb-build && debuild --no-tgz-check -uc -us
 
+.PHONY: rpm-kcps
 rpm-kcps: rpm-kcps-v1 rpm-kcps-v2
+
+.PHONY: rpm-kcps-v1
 rpm-kcps-v1: crossbuild-package-kcps
 	MACKEREL_AGENT_NAME=mackerel-agent-kcps _tools/packaging/prepare-rpm-build.sh
 	docker run --rm -v "$(PWD)":/workspace -v "$(PWD)/rpmbuild":/rpmbuild astj/mackerel-rpm-builder:c5 \
@@ -114,49 +136,61 @@ rpm-kcps-v1: crossbuild-package-kcps
 	--define "_version ${VERSION}" --define "buildarch x86_64" \
 	-bb packaging/rpm-build/mackerel-agent-kcps.spec
 
+.PHONY: rpm-kcps-v2
 rpm-kcps-v2: crossbuild-package-kcps
 	BUILD_SYSTEMD=1 MACKEREL_AGENT_NAME=mackerel-agent-kcps _tools/packaging/prepare-rpm-build.sh
 	docker run --rm -v "$(PWD)":/workspace -v "$(PWD)/rpmbuild":/rpmbuild astj/mackerel-rpm-builder:c7 \
 	--define "_sourcedir /workspace/packaging/rpm-build/src" --define "_builddir /workspace/build-linux-amd64" \
 	--define "_version ${VERSION}" --define "buildarch x86_64" \
 	-bb packaging/rpm-build/mackerel-agent-kcps.spec
 
+.PHONY: deb-kcps
 deb-kcps: deb-kcps-v1 deb-kcps-v2
 
+.PHONY: deb-kcps-v1
 deb-kcps-v1: crossbuild-package-kcps
 	MACKEREL_AGENT_NAME=mackerel-agent-kcps BUILD_DIRECTORY=build-linux-386 _tools/packaging/prepare-deb-build.sh
 	cd packaging/deb-build && debuild --no-tgz-check -uc -us
 
+.PHONY: deb-kcps-v2
 deb-kcps-v2: crossbuild-package-kcps
 	MACKEREL_AGENT_NAME=mackerel-agent-kcps BUILD_SYSTEMD=1 BUILD_DIRECTORY=build-linux-amd64 _tools/packaging/prepare-deb-build.sh
 	cd packaging/deb-build && debuild --no-tgz-check -uc -us
 
+.PHONY: rpm-stage
 rpm-stage: rpm-stage-v1 rpm-stage-v2
+
+.PHONY: rpm-stage-v1
 rpm-stage-v1: crossbuild-package-stage
 	MACKEREL_AGENT_NAME=mackerel-agent-stage _tools/packaging/prepare-rpm-build.sh
 	docker run --rm -v "$(PWD)":/workspace -v "$(PWD)/rpmbuild":/rpmbuild astj/mackerel-rpm-builder:c5 \
 	--define "_sourcedir /workspace/packaging/rpm-build/src" --define "_builddir /workspace/build-linux-386" \
 	--define "_version ${VERSION}" --define "buildarch noarch" \
 	-bb packaging/rpm-build/mackerel-agent-stage.spec
 
+.PHONY: rpm-stage-v2
 rpm-stage-v2: crossbuild-package-stage
 	BUILD_SYSTEMD=1 MACKEREL_AGENT_NAME=mackerel-agent-stage _tools/packaging/prepare-rpm-build.sh
 	docker run --rm -v "$(PWD)":/workspace -v "$(PWD)/rpmbuild":/rpmbuild astj/mackerel-rpm-builder:c7 \
 	--define "_sourcedir /workspace/packaging/rpm-build/src" --define "_builddir /workspace/build-linux-amd64" \
 	--define "_version ${VERSION}" --define "buildarch x86_64" \
 	-bb packaging/rpm-build/mackerel-agent-stage.spec
 
+.PHONY: deb-stage
 deb-stage: deb-stage-v1 deb-stage-v2
 
+.PHONY: deb-stage-v1
 deb-stage-v1: crossbuild-package-stage
 	MACKEREL_AGENT_NAME=mackerel-agent-stage BUILD_DIRECTORY=build-linux-386 _tools/packaging/prepare-deb-build.sh
 	cd packaging/deb-build && debuild --no-tgz-check -uc -us
 
+.PHONY: deb-stage-v2
 deb-stage-v2: crossbuild-package-stage
 	MACKEREL_AGENT_NAME=mackerel-agent-stage BUILD_SYSTEMD=1 BUILD_DIRECTORY=build-linux-amd64 _tools/packaging/prepare-deb-build.sh
 	cd packaging/deb-build && debuild --no-tgz-check -uc -us
 
 tgz_dir = "build/tgz/$(MACKEREL_AGENT_NAME)"
+.PHONY: tgz
 tgz:
 	GOOS=linux GOARCH=386 make build
 	rm -rf $(tgz_dir)
@@ -165,6 +199,7 @@ tgz:
 	cp build/$(MACKEREL_AGENT_NAME) $(tgz_dir)/
 	tar cvfz build/$(MACKEREL_AGENT_NAME)-latest.tar.gz -C build/tgz $(MACKEREL_AGENT_NAME)
 
+.PHONY: check-release-deps
 check-release-deps:
 	@have_error=0; \
 	for command in cpanm hub ghch gobump; do \
@@ -175,12 +210,12 @@ check-release-deps:
 	done; \
 	test $$have_error = 0
 
+.PHONY: release
 release: check-release-deps
 	(cd _tools && cpanm -qn --installdeps .)
 	perl _tools/create-release-pullrequest
 
+.PHONY: clean
 clean:
 	rm -f build/$(MACKEREL_AGENT_NAME) build-linux-amd64/$(MACKEREL_AGENT_NAME) build-linux-386/$(MACKEREL_AGENT_NAME)
 	go clean
-
-.PHONY: test build run deps clean lint crossbuild cover rpm deb tgz crossbuild-package crossbuild-package-kcps crossbuild-package-stage rpm-v1 rpm-v2 rpm-stage rpm-stage-v1 rpm-stage-v2 rpm-kcps-v1 rpm-kcps-v2 deb-v1 deb-v2 deb-kcps deb-kcps-v1 deb-kcps-v2 deb-stage deb-stage-v1 deb-stage-v2 release check-release-deps