Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nit] fix comment of supervisor #345

Merged
merged 1 commit into from
Feb 24, 2017

Conversation

haya14busa
Copy link
Contributor

The comment meant following code

if c == nil {
	c = make(chan os.Signal, 1)
	defer close(c)
}

but it actually looks like this

if c == nil {
	c = make(chan os.Signal, 1)
}
defer close(c)

I think both are fine but comment should be true.

ref: #327 (comment)

The comment meant following code

	if c == nil {
		c = make(chan os.Signal, 1)
		defer close(c)
	}

but it actually looks like this

	if c == nil {
		c = make(chan os.Signal, 1)
	}
	defer close(c)

I think both are fine but comment should be true.

ref: mackerelio#327 (comment)
@Songmu
Copy link
Contributor

Songmu commented Feb 24, 2017

🙇 Thanks!

@Songmu Songmu merged commit 89c2008 into mackerelio:master Feb 24, 2017
@Songmu Songmu changed the title fix comment of supervisor [nit] fix comment of supervisor Feb 24, 2017
@haya14busa haya14busa deleted the fix-comment-of-supervisor branch February 24, 2017 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants