migrate to use mkr.XxxHostParam instead of mackerel.HostSpec #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lufia
changed the title
lufia
changed the title
…l.HostSpec a member Checks of both mkr.Create- and Update-HostParam is tagged with json:omitempty. therefore TestCreateHost is modify a statement to pass the test.
astj
approved these changes
May 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced
mackerel.HostSpecwith bothmkr.CreateHostParamandmkr.UpdateHostParam.notice
In this p-r, I modified a statement to pass the test because a member Checks of both mkr.Create- and Update-HostParam is tagged with json:omitempty, so unmarshalled object become a nil.
done
This p-r must merge after #553 and mackerelio/mackerel-client-go#87