Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to fit #557 into our workflow. #577

Merged
merged 13 commits into from Jul 24, 2019

Conversation

hayajo
Copy link
Contributor

@hayajo hayajo commented Jul 18, 2019

Ref #557.
Thank you, @tnishinaga

  • Build arm64 and mips binary at the crossbuild-package task
  • Build deb packeages for arm64 and mips at the dev-v2 task
  • Build deb packages in Dockerlized environment

@astj
Copy link
Contributor

astj commented Jul 18, 2019

@hayajo (and @tnishinaga ) This p-r and #557 will build only systemd-based deb package for arm and mips. I hope this will satisfy major use cases, but in some cases it might not fit. For example, if you want to install mackerel-agent into some limited environment which does not use systemd, like NAS/router with busybox, this deb will not work since they works on top of systemd.
Do you think current artifacts are enough for use cases?

@@ -9,7 +9,7 @@ Vcs-Git: https://github.com/mackerelio/mackerel-agent.git
Homepage: https://mackerel.io

Package: mackerel-agent
Architecture: amd64
Architecture: any
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref: https://www.debian.org/doc/debian-policy/ch-controlfields.html#architecture

When any, produced binary package will have specific architecture (amd64, mips, etc…), which is desired behavior.

@@ -18,5 +18,10 @@ packaging/deb/debian/mackerel-agent.bin
packaging/*.tar.gz
packaging/deb-build
packaging/rpm-build
packaging/*.deb
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, should we change directory structure to be more gitignore-friendly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be nice to put the artifacts in one directory.
But we also need to fix other tools, so let's discuss in another issue.

@@ -9,13 +9,6 @@ env:
- PATH=/home/travis/gopath/bin:$PATH DEBIAN_FRONTEND=noninteractive
- secure: "VG3xbEjFSuB80QBFchHZqQDB4VF74RTXaNSBPl/bavGr9My2RSqtfXqfEGUHFwo5zPM7LA0bIEC7jsobf6M6vtfVgJKOOXEfF/pfD83n++eHZe0yLN6Wysp1Bn14KH+ont550gDityORqEvX3pK4k9hSb8dXpjGnCtrAwqAS+eg="
- GO111MODULE=on
addons:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Contributor

@astj astj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems okay so I'd like to approve

@hayajo hayajo merged commit 35e37ea into master Jul 24, 2019
@hayajo hayajo mentioned this pull request Jul 30, 2019
@astj astj deleted the tnishinaga-WIP-crossbuild-deb-cleanup branch September 11, 2019 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants