Check command name on pid check for pid confliction after OS restart #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
pid-check-command-name
branch
from
730d87e
to
7b36b5e
Compare
itchyny
force-pushed
the
pid-check-command-name
branch
2 times, most recently
from
1ca9ef6
to
88dd365
Compare
itchyny
force-pushed
the
pid-check-command-name
branch
from
88dd365
to
6590622
Compare
astj
approved these changes
Jul 25, 2019
|
Thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On unexpected OS restart, there happens that different process uses the same pid as mackerel-agent before restart. We should start the mackerel-agent, when it finds a process matching the old pid file but is not mackerel-agent.