update go: 1.12 -> 1.14 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iven Package ./command has some tests to fail to post the metrics. In these tests, though the mackerel-agent will retry to post the metrics, go test ends up timed out after 10 minutes because the agent sleeps a minute by default before next posting if previous post was failed. If the -short option is given, it will sleeps shorter than default, so all tests will be passed. The tests of ./command requires -short flag. This is by design.
pyto86pri
approved these changes
Aug 13, 2020
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated go toolchain, and pinned dev tools with go module.