Support fetch command to retrieve many hosts #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
force-pushed
the
mkr-fetch-many-hosts
branch
from
c65d59e
to
761e402
Compare
astj
reviewed
Sep 13, 2017
| @@ -453,6 +453,17 @@ func doThrow(c *cli.Context) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func split(ids []string, count int) [][]string { | |||
| xs := make([][]string, 0, (len(ids)+count-1)/count) | |||
There was a problem hiding this comment.
Panics when count == 0, but it should not happen..
commands.go
Outdated
| for _, hostIds := range split(argHostIDs, 100) { | ||
| metricValues, err := newMackerelFromContext(c).FetchLatestMetricValues(hostIds, optMetricNames) | ||
| logger.DieIf(err) | ||
| for metricName := range metricValues { |
There was a problem hiding this comment.
[nit]
The key of LatestMetricValues is actually hostId, not metricName.
(As long as mkr and mackerel-client-go's definition, it's perfectly unknown what key of LatestMetricValues is, so imo it's good to use some ambiguous name like key...)
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes mkr fetch command to fetch huge number of hosts per one command.