Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric-names subcommand. #561

Merged
merged 2 commits into from May 16, 2023
Merged

Conversation

fujiwara
Copy link
Contributor

@fujiwara fujiwara commented Apr 26, 2023

Hi. I added metric-names subcommand.

metric-names fetches metric names of the host or service.

mkr metric-names --help
NAME:
   mkr metric-names - Fetch metric names

USAGE:
   mkr metric-names [command options] [--host | -H <hostId>] [--service | -s <service>] [--jq <formula>]

DESCRIPTION:
   
    Fetch metric names of 'host metric' or 'service metric'.
    Requests "/api/v0/hosts/<hostId>/metric-names" or "/api/v0/services/<serviceName>/metric-names".
    See https://mackerel.io/ja/api-docs/entry/hosts#metric-names, https://mackerel.io/ja/api-docs/entry/services#metric-names


OPTIONS:
   --host value, -H value     Fetch host metric names of <hostID>.
   --service value, -s value  Fetch service metric names of <service>.
   --jq value                 Filter response values using jq syntax

metrics-names fetches metric names of the host or service.
@fujiwara fujiwara changed the title Add metic-names sub command. Add metric-names subcommand. Apr 26, 2023
@lufia
Copy link
Member

lufia commented Apr 28, 2023

Hi! Thank you for your contributions.

We are going to review this PR next week.

Copy link
Contributor

@yseto yseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good. please rewrite commands Description.

metric_names/command.go Outdated Show resolved Hide resolved
@yseto yseto merged commit ee2bd4a into mackerelio:master May 16, 2023
3 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants