Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ship types.d.ts #5

Closed
macklinu opened this issue May 24, 2017 · 0 comments · Fixed by #7
Closed

Ship types.d.ts #5

macklinu opened this issue May 24, 2017 · 0 comments · Fixed by #7
Labels
bug

Comments

@macklinu
Copy link
Owner

There are no consumable types when installing from npm. I'd like to generate them from source code, but I could also define a types file for 1.0.x and come back to generating types later.
@macklinu macklinu added the bug label May 24, 2017
This was referenced May 24, 2017
Closed
Merged
macklinu added a commit that referenced this issue May 26, 2017
@macklinu
feat(tslint): change plugin API (#7)
0fec7e2 
This commit changes the API to load the TSLint results JSON file from disk instead of using TSLint's
programmatic API to run TSLint. While this requires an extra setup step for users, this allows this
plugin to be functional (v1.0.0 did not work properly).

This commit also resolves #5.

BREAKING CHANGE: there is a new configuration API, so this will result in a major version bump.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tslint): change plugin API macklinu/danger-plugin-tslint
1 participant
@macklinu