style(lint): enable es5/no-destructuring rule

jest-community#64 (comment) jest-community#56 (comment)
macklinu · Feb 10, 2018 · 236d098 · 236d098
1 parent 18c97de
commit 236d098
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -8,7 +8,7 @@ module.exports = {
     'plugin:eslint-plugin/recommended',
     'prettier',
   ],
-  plugins: ['eslint-plugin', 'prettier'],
+  plugins: ['es5', 'eslint-plugin', 'prettier'],
   parserOptions: {
     ecmaVersion: 2017,
   },
@@ -18,6 +18,7 @@ module.exports = {
   rules: {
     eqeqeq: ['error', 'smart'],
     strict: 'error',
+    'es5/no-destructuring': 'error',
     'eslint-plugin/require-meta-docs-url': [
       'error',
       {

diff --git a/dangerfile.js b/dangerfile.js
@@ -1,5 +1,6 @@
 'use strict';
 
+// eslint-disable-next-line es5/no-destructuring
 const { danger, fail } = require('danger');
 
 // Ensure that people include a description on their PRs

diff --git a/package.json b/package.json
@@ -47,5 +47,8 @@
   },
   "commitlint": {
     "extends": ["@commitlint/config-conventional"]
+  },
+  "dependencies": {
+    "eslint-plugin-es5": "^1.2.0"
   }
 }
diff --git a/yarn.lock b/yarn.lock
@@ -1587,6 +1587,10 @@ eslint-config-prettier@^2.7.0:
   dependencies:
     get-stdin "^5.0.1"
 
+eslint-plugin-es5@^1.2.0:
+  version "1.2.0"
+  resolved "https://registry.yarnpkg.com/eslint-plugin-es5/-/eslint-plugin-es5-1.2.0.tgz#22e1e7d5681b3a2f2588247bc9ca51dbfee6f6e9"
+
 eslint-plugin-eslint-plugin@^1.4.0:
   version "1.4.0"
   resolved "https://registry.yarnpkg.com/eslint-plugin-eslint-plugin/-/eslint-plugin-eslint-plugin-1.4.0.tgz#382dc6692a741a52072d5f3fff5dacdcf291ef49"