Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvement: Use TypeCache instead of manual type iteration #56

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Performance improvement: Use TypeCache instead of manual type iteration #56

merged 1 commit into from
Apr 1, 2024

Conversation

theo-rapidfire
Copy link
Contributor

fix/use-type-cache

Description

The PropertyDrawerType cache generation had a performance bottleneck, which could be resolved by using Unity's TypeCache.

Performance before:

  1. Selecting Item A
    image
  2. Selecting Item B
    image

Performance after:

  1. Selecting Item A
    image
  2. Selecting Item B
    image

Changes made

  • Converted PropertyDrawerCache type detection to use TypeCache

@theo-rapidfire theo-rapidfire changed the title Use TypeCache instead of manual type iteration Performance improvement: Use TypeCache instead of manual type iteration Mar 29, 2024
@mackysoft mackysoft merged commit 2b40c3d into mackysoft:main Apr 1, 2024
1 of 2 checks passed
@mackysoft
Copy link
Owner

Function confirmed. Thanks @theo-rapidfire !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theo-rapidfire @mackysoft