Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bundler version dependencies #157

Open
nelliemckesson opened this issue Jan 17, 2017 · 3 comments
Open

remove bundler version dependencies #157

nelliemckesson opened this issue Jan 17, 2017 · 3 comments

Comments

@nelliemckesson
Copy link
Contributor

nelliemckesson commented Jan 17, 2017

@mattretzer I think we should remove the version dependencies in bundler whenever possible. It causes bookmaker to crash if any gem versions are out of date, which is bad. But I'm open to other arguments.

@mattretzer
Copy link
Contributor

Wow, I don't think that's supposed to happen :(
Let me know if you want me to change this today or if we can wait and discuss Thursday?

@nelliemckesson
Copy link
Contributor Author

Let's discuss Thursday. FYI this was when I was running it on my local machine, which comes with some extra issues, so presumably it wouldn't crash on the server versions.

@stefanv
Copy link

stefanv commented Feb 13, 2017

I've run into this issue as well. It may be worth reviewing the README installation instructions as well; they don't work unmodified (at least, not on a modern OSX brew system). E.g., note:

  • Current dependencies cannot be installed under Ruby 1.9 (the version advocated)
  • Dependencies can be installed as follows (I'm not a Ruby user, so I don't know if this is the best way):
gem install bundler
bundler install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants