Implemented Level indicator #30

bdlukaa · 2021-04-16T16:44:55Z

Continuous capacity indicator
Discrete capacity indicator
Rating indicator
Relevance indicator

GroovinChip

Ensure dartfmt and optimize imports have been run on all changed files in addition to other requested changes.

lib/src/indicators/rating_indicator.dart

GroovinChip

Track colors for CapacityIndicators and RelevanceIndicator are not correct for light theme

bdlukaa · 2021-04-18T18:17:44Z

@GroovinChip This is actually an issue with the MacosTheme. CupertinoDynamicColor.resolveFrom uses CupertinoTheme.maybeBrightnessOf(context), that uses MediaQuery.maybeOf(context)?.platformBrightness for color fallback. A CupertinoTheme should be provided by the MacosTheme with the brightness, otherwise all the widgets that uses CupertinoDynamicColor.resolve() will use the device's brightness instead of the one provided in MacosTheme.

GroovinChip · 2021-04-18T19:32:40Z

@GroovinChip This is actually an issue with the MacosTheme. CupertinoDynamicColor.resolveFrom uses CupertinoTheme.maybeBrightnessOf(context), that uses MediaQuery.maybeOf(context)?.platformBrightness for color fallback. A CupertinoTheme should be provided by the MacosTheme with the brightness, otherwise all the widgets that uses CupertinoDynamicColor.resolve() will use the device's brightness instead of the one provided in MacosTheme.

@bdlukaa I think this will be resolved by #43

Edit: Actually no. This is a step forward, but not the complete solution. I don't think a CupertinoTheme should be added to MacosTheme. Rather, I think that we should have an extension on CupertinoDynamicColor that calls the new MacosTheme.maybeBrightnessOf(context) and handles things accordingly.

…ing #30

…ing #30 (#45)

…vel_indicator

I also made some changes to styles/colors.dart

GroovinChip

LGTM

* Update CONTRIBUTING.md * Theming and styles (#8) * Start work on theme Contains a super barebones theme.dart, shamelessly copied from https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/styles/theme.dart * More theme work (9:50 AM March 30) * New macos_app.dart * Placeholer Typography in theme.dart from material * Add some todos/fixmes * Start work on theme Contains a super barebones theme.dart, shamelessly copied from https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/styles/theme.dart * More theme work (9:50 AM March 30) * New macos_app.dart * Placeholer Typography in theme.dart from material * Add some todos/fixmes * Add Apple SF Pro fonts * Add typography.dart * Add basic documentation to typography.dart * Minor tweaks to macos_app.dart * Use CupertinoColors.systemBlue for default color * Rename color to primaryColor * Improvements to theming, root app; first new (experimental) widget: Scaffold! * Remove print * Add not implemented comments * Update README.md with Content section This is very early and is mostly a placeholder * Add animationCurve and mediumAnimationDuration to Style class (#10) Also add repo url to pubspec.yaml * Version 0.0.2 (#11) * Major Updates for Scaffold * Adds SplitView for expanded/shrinking the sidebar * Removed rightSidebar * Lots of customizable properties related to the sidebar * Documentation Additional changes: * Update typography.dart so that the color is properly shown. * Update version * Update README.md * Update CHANGELOG.md * Update license (#12) * MIT License * Use null-safe split-view from git. Tweak Scaffold accordingly . (#13) * Add dart_code_metrics package * Improve code_metrics and address warnings (#17) * Add metrics to configuration * Sort scaffold.dart public members * Sort macos_app.dart public members * Sort theme.dart public members * Sort typography.dart public members * Update to latest code_metrics * Rework on MacosApp (#18) * Rework on MacosApp Reworked MacosApp to use CupertinoApp as a backend. This has several improvements: - Apple-styled scrolling - Using the San Francisco font by default I also added documentation for all the properties * Fixed references iOS -> macOS color -> primaryColor * Update to latest code_metrics and stop requiring alphabetically-sorted class members * Add primaryColor to Style (#19) Renames MacosApp's primaryColor to simply "color" as a result. * Implemented Switch (#21) * Implemented Switch - MacosTheme.maybeOf now can return a nullable value - Added Switch to Example app * Bump version * Implement Progress Indicators * Sort constructors first, run optimize imports * Update progress_indicators.dart docs * Update readme (#23) * Update README.md with Switch, ProgressCircle, and ProgressBar * Reduce image sizes, update indeterminate ProgressCircle file extension * Converted to gif * Fix unreachable content * Theme refactor (#29) * Add primaryColor to Style Renames MacosApp's primaryColor to simply "color" as a result. * Major theme refactor that more closely resembles flutter/material and flutter/cupertino * The `Style` class is now `MacosThemeData` * `MacosTheme` is now a `StatelessWidget` that returns a private `_InheritedMacosTheme`. The static `MacosTheme.of(context)` is now defined here. * `MacosApp` now takes a `theme` and `darkTheme` rather than `style` and `darkStyle`. Additionally, there are minor changes to the way `MacosApp` is built that more closely resemble how `MaterialApp` is built. Inspired by: * material/theme.dart * material/theme_data.dart * material/app.dart * cupertino/theme.dart * Stop setting explicit active colors since the theme will always have a color * Update README.md and CONTRIBUTING.md (#33) * README.md now mentions CONTRIBUTING.md * CONTRIBUTING.md has been updated with branch structure and versioning information * Add pull request template (#34) * Add workflows/pana_analysis.yml (#35) * Add workflows/pana_analysis.yml * Use split_view from pub Author merged my null-safety PR a while back and I forgot to update. This addresses an analyzer warning and also should allow the pana_analysis action to run. * Run `dartfmt -w .` per pana report * Push button (#40) * Stub out buttons with corresponding Styles * Stub out Fields and Labels with corresponding Styles * Stub out Selectors * Placeholder Indicators * Remove stubs for RoundButton and BevelButton Apple docs say not to use these * Start working on PushButton * Get PushButton color from style's primaryColor instead of PushButton's disabledColor Also: * Add button_states.dart * Add PushButtonStyle stub to Style * Add Diagnosticable mixin to PushButtonStyle * Tweak PushButton's disabledColor * Start work on PushButtonStyle * Add color, disabledColor, padding, and borderRadius properties to class with contructor and corresponding debug properties * Include PushButtonStyle when returning default style in theme.dart * Get PushButton color from current style if possible, otherwise fall back to defaults * Add todos for implementing other PushButtonStyle props in PushButton * Use proper padding and border radius for small and large PushButtons * Test PushButton in example app * Export push_button_theme.dart, move todo * Documentation updates * Documentation for PushButtonTheme and PushButtonThemeData * Tweak MacosThemeData documentation * Revert stubs * Update version and CHANGELOG.md * Ensure text color is correct when PushButton is disabled * Add PushButton section to README.md * Try embedding PushButton images as an album * Try embedding PushButton images as an album (2) * Revert to individual images * Improve Typography (#41) * Add letter spacing to all TextStyles that require it Also make headline's letter spacing negative, per spec * Add fontWeights to TextStyles * Update PushButton images in README.md * Update version, CHANGELOG.md * Add `brightnessOf` and `maybeBrightness of` to `MacosTheme` (#43) * Add `brightnessOf` and `maybeBrightness of` Also add documentation to `of` * Update CHANGELOG.md * Add extensions on CupertinoDynamicColor to try and solve what's blocking #30 (#45) * Implemented Level indicator (#30) * Implement capacity indicator * Implemented rating indicator * Implemented relevance indicator * Implemented gesture detector for indicators * Updated theme * Fixed colors I also made some changes to styles/colors.dart * Update colors.dart * Add workflow_dispatch to enable manual runs via gh cli (#46) * Implement RadioButton and Checkbox (#47) * Implemented checkbox * Implemented RadioButton * Updated the theme to match the latest dev * Updated radio button * Update CHANGELOG.md * Fixed radio button in light theme and added shadows * Fixed checkbox light theme * Fixed pubspec * Improved colors * CHORE: bump version * Fixed #49 The GestureDetector applied to capacity indicator should be added inside of the Container. Fixes #49 Bumped version to 0.0.8 * Implemented Help Button (#51) * Implemented Help Button * Implemented Help Button * Implemented Help Button * Implemented Help Button * Implemented Help Button * Update CI with "Format scores json" step (#54) * Update CI with "Format scores json" step Useful for PR's across forks * Docs for new step * fix indentation issue * Readme update (#55) * Documentation about checkbox * Documentation about radio button * Documentation about push button * Documentation about toggle switch * Documentation about indicators * Documentation about help buttons * Squashed commit of the following: commit 617ea07 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:55:11 2021 -0400 spacing commit 4e20615 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:28:51 2021 -0400 Use correct branch name commit e2a2b97 Merge: 80753df df70270 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:27:36 2021 -0400 Merge branch 'dev' into gh_pages commit 80753df Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 18:45:40 2021 -0400 Add GH Pages action * change base href * Squashed commit of the following: commit 81b9ac34100622c35cdac752e527a73f49197806 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 22:06:32 2021 -0400 change base href commit d633c3e Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:55:35 2021 -0400 Fix env commit 995f648 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:53:02 2021 -0400 tweak token usage commit 23552c6 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:43:50 2021 -0400 Switch back to my email/username commit 32dc277 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:38:11 2021 -0400 Simplify deploy commit b604090 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:32:04 2021 -0400 Change git config commit d18c134 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:26:49 2021 -0400 Fix indentation commit bcf5ec1 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:25:32 2021 -0400 Remove unnecessary steps and use "working-directory" commit f02cbd7 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:19:58 2021 -0400 Fix paths commit 7dc28be Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:17:17 2021 -0400 Add cd into example commit 3761559 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:13:50 2021 -0400 Try a different action deploying to gh pages * Code Improvements (#58) * Documentation about checkbox * Documentation about radio button * Documentation about push button * Documentation about toggle switch * Documentation about indicators * Documentation about help buttons * Code improvements * Changes * Introduce library.dart Moving flutter exports from macos_ui.dart to library.dart allows documentation to be generated only for files belonging to macos_ui. * Fix placement of package level documentation * Address pana warning Co-authored-by: Reuben Turner <groovinchip@gmail.com> * update base href * Update PR template * Update issue templates * Update package description * Scaffold (#52) * remove split_view package * create title_bar * create sidebar * create content_area * remove titlebar in MainFlutterWindow.swift * Update pubspec.lock * create resizable_pane * create resizable_pane_notifier * Update scaffold.dart * Update macos_ui.dart * Update main.dart * [example] add resizable pane * add dividerColor to MacosThemeData * use BoxDecoration in Sidebar * use SafeArea in ContentArea * update ResizablePane * update scaffold * make `ResizablePane` `const` * make `Sidebar` `const` * make `TitleBar` `const` * make `Scaffold` `const` * Update CHANGELOG.md * Update resizable_pane.dart * add maybeOf to scaffold * Update macos_ui.dart * Update scaffold.dart * add `scaffoldBreakpoint` to `sidebar` * use sidebar breakpoint and toggling in `Scaffold` * use `scaffoldBreakpoint` in `ResizablePane` * update example * Address some requested changes Co-authored-by: Reuben Turner <groovinchip@gmail.com> * Text field (#62) * Implemented TextField And fixed macos resolve color * Formatted code * Update README.md * Border * Fixed text field border to match the latest design * Focused border animation * Fix formatting error * Update placeholder text in demo * Update version, CHANGELOG.md Co-authored-by: Reuben Turner <groovinchip@gmail.com> * Implement mouse cursors (#67) * Implemente mouse cursors * Removed mouse cursor from checkbox and radio button * Implemented mouse cursor for text field * Bump version * Implement Tooltip (#68) * Implement tooltip * Bump version and update readme * Format files * Fixed typo * Update Scaffold images (#72) * Update Scaffold images * Address analyzer warnings * Constructors first * Remove unnecessary statement * Adjust failing score (#75) * Adjust failing score * Address warning * Run dartfmt * Re-adjust scoring * Re-adjust scoring again * Re-adjust scoring again! * Use correct score * Adjust spacing between elements in demo (#76) * Update documentation (#77) * update `resizable_pane_notifier` documentation * update `ScaffoldScope` documentation * Update CHANGELOG.md * Move to v 0.1.0 * Run optimize imports and dartfmt on all files Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com> Co-authored-by: Harshvardhan Singh Bhadouria <66870883+harshvsb1105@users.noreply.github.com> Co-authored-by: Leslie Arkorful <lesliearkorful@gmail.com>

* Update CONTRIBUTING.md * Theming and styles (#8) * Start work on theme Contains a super barebones theme.dart, shamelessly copied from https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/styles/theme.dart * More theme work (9:50 AM March 30) * New macos_app.dart * Placeholer Typography in theme.dart from material * Add some todos/fixmes * Start work on theme Contains a super barebones theme.dart, shamelessly copied from https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/styles/theme.dart * More theme work (9:50 AM March 30) * New macos_app.dart * Placeholer Typography in theme.dart from material * Add some todos/fixmes * Add Apple SF Pro fonts * Add typography.dart * Add basic documentation to typography.dart * Minor tweaks to macos_app.dart * Use CupertinoColors.systemBlue for default color * Rename color to primaryColor * Improvements to theming, root app; first new (experimental) widget: Scaffold! * Remove print * Add not implemented comments * Update README.md with Content section This is very early and is mostly a placeholder * Add animationCurve and mediumAnimationDuration to Style class (#10) Also add repo url to pubspec.yaml * Version 0.0.2 (#11) * Major Updates for Scaffold * Adds SplitView for expanded/shrinking the sidebar * Removed rightSidebar * Lots of customizable properties related to the sidebar * Documentation Additional changes: * Update typography.dart so that the color is properly shown. * Update version * Update README.md * Update CHANGELOG.md * Update license (#12) * MIT License * Use null-safe split-view from git. Tweak Scaffold accordingly . (#13) * Add dart_code_metrics package * Improve code_metrics and address warnings (#17) * Add metrics to configuration * Sort scaffold.dart public members * Sort macos_app.dart public members * Sort theme.dart public members * Sort typography.dart public members * Update to latest code_metrics * Rework on MacosApp (#18) * Rework on MacosApp Reworked MacosApp to use CupertinoApp as a backend. This has several improvements: - Apple-styled scrolling - Using the San Francisco font by default I also added documentation for all the properties * Fixed references iOS -> macOS color -> primaryColor * Update to latest code_metrics and stop requiring alphabetically-sorted class members * Add primaryColor to Style (#19) Renames MacosApp's primaryColor to simply "color" as a result. * Implemented Switch (#21) * Implemented Switch - MacosTheme.maybeOf now can return a nullable value - Added Switch to Example app * Bump version * Implement Progress Indicators * Sort constructors first, run optimize imports * Update progress_indicators.dart docs * Update readme (#23) * Update README.md with Switch, ProgressCircle, and ProgressBar * Reduce image sizes, update indeterminate ProgressCircle file extension * Converted to gif * Fix unreachable content * Theme refactor (#29) * Add primaryColor to Style Renames MacosApp's primaryColor to simply "color" as a result. * Major theme refactor that more closely resembles flutter/material and flutter/cupertino * The `Style` class is now `MacosThemeData` * `MacosTheme` is now a `StatelessWidget` that returns a private `_InheritedMacosTheme`. The static `MacosTheme.of(context)` is now defined here. * `MacosApp` now takes a `theme` and `darkTheme` rather than `style` and `darkStyle`. Additionally, there are minor changes to the way `MacosApp` is built that more closely resemble how `MaterialApp` is built. Inspired by: * material/theme.dart * material/theme_data.dart * material/app.dart * cupertino/theme.dart * Stop setting explicit active colors since the theme will always have a color * Update README.md and CONTRIBUTING.md (#33) * README.md now mentions CONTRIBUTING.md * CONTRIBUTING.md has been updated with branch structure and versioning information * Add pull request template (#34) * Add workflows/pana_analysis.yml (#35) * Add workflows/pana_analysis.yml * Use split_view from pub Author merged my null-safety PR a while back and I forgot to update. This addresses an analyzer warning and also should allow the pana_analysis action to run. * Run `dartfmt -w .` per pana report * Push button (#40) * Stub out buttons with corresponding Styles * Stub out Fields and Labels with corresponding Styles * Stub out Selectors * Placeholder Indicators * Remove stubs for RoundButton and BevelButton Apple docs say not to use these * Start working on PushButton * Get PushButton color from style's primaryColor instead of PushButton's disabledColor Also: * Add button_states.dart * Add PushButtonStyle stub to Style * Add Diagnosticable mixin to PushButtonStyle * Tweak PushButton's disabledColor * Start work on PushButtonStyle * Add color, disabledColor, padding, and borderRadius properties to class with contructor and corresponding debug properties * Include PushButtonStyle when returning default style in theme.dart * Get PushButton color from current style if possible, otherwise fall back to defaults * Add todos for implementing other PushButtonStyle props in PushButton * Use proper padding and border radius for small and large PushButtons * Test PushButton in example app * Export push_button_theme.dart, move todo * Documentation updates * Documentation for PushButtonTheme and PushButtonThemeData * Tweak MacosThemeData documentation * Revert stubs * Update version and CHANGELOG.md * Ensure text color is correct when PushButton is disabled * Add PushButton section to README.md * Try embedding PushButton images as an album * Try embedding PushButton images as an album (2) * Revert to individual images * Improve Typography (#41) * Add letter spacing to all TextStyles that require it Also make headline's letter spacing negative, per spec * Add fontWeights to TextStyles * Update PushButton images in README.md * Update version, CHANGELOG.md * Add `brightnessOf` and `maybeBrightness of` to `MacosTheme` (#43) * Add `brightnessOf` and `maybeBrightness of` Also add documentation to `of` * Update CHANGELOG.md * Add extensions on CupertinoDynamicColor to try and solve what's blocking #30 (#45) * Implemented Level indicator (#30) * Implement capacity indicator * Implemented rating indicator * Implemented relevance indicator * Implemented gesture detector for indicators * Updated theme * Fixed colors I also made some changes to styles/colors.dart * Update colors.dart * Add workflow_dispatch to enable manual runs via gh cli (#46) * Implement RadioButton and Checkbox (#47) * Implemented checkbox * Implemented RadioButton * Updated the theme to match the latest dev * Updated radio button * Update CHANGELOG.md * Fixed radio button in light theme and added shadows * Fixed checkbox light theme * Fixed pubspec * Improved colors * CHORE: bump version * Fixed #49 The GestureDetector applied to capacity indicator should be added inside of the Container. Fixes #49 Bumped version to 0.0.8 * Implemented Help Button (#51) * Implemented Help Button * Implemented Help Button * Implemented Help Button * Implemented Help Button * Implemented Help Button * Update CI with "Format scores json" step (#54) * Update CI with "Format scores json" step Useful for PR's across forks * Docs for new step * fix indentation issue * Readme update (#55) * Documentation about checkbox * Documentation about radio button * Documentation about push button * Documentation about toggle switch * Documentation about indicators * Documentation about help buttons * Squashed commit of the following: commit 617ea07 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:55:11 2021 -0400 spacing commit 4e20615 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:28:51 2021 -0400 Use correct branch name commit e2a2b97 Merge: 80753df df70270 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:27:36 2021 -0400 Merge branch 'dev' into gh_pages commit 80753df Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 18:45:40 2021 -0400 Add GH Pages action * change base href * Squashed commit of the following: commit 81b9ac34100622c35cdac752e527a73f49197806 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 22:06:32 2021 -0400 change base href commit d633c3e Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:55:35 2021 -0400 Fix env commit 995f648 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:53:02 2021 -0400 tweak token usage commit 23552c6 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:43:50 2021 -0400 Switch back to my email/username commit 32dc277 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:38:11 2021 -0400 Simplify deploy commit b604090 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:32:04 2021 -0400 Change git config commit d18c134 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:26:49 2021 -0400 Fix indentation commit bcf5ec1 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:25:32 2021 -0400 Remove unnecessary steps and use "working-directory" commit f02cbd7 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:19:58 2021 -0400 Fix paths commit 7dc28be Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:17:17 2021 -0400 Add cd into example commit 3761559 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:13:50 2021 -0400 Try a different action deploying to gh pages * Code Improvements (#58) * Documentation about checkbox * Documentation about radio button * Documentation about push button * Documentation about toggle switch * Documentation about indicators * Documentation about help buttons * Code improvements * Changes * Introduce library.dart Moving flutter exports from macos_ui.dart to library.dart allows documentation to be generated only for files belonging to macos_ui. * Fix placement of package level documentation * Address pana warning Co-authored-by: Reuben Turner <groovinchip@gmail.com> * update base href * Update PR template * Update issue templates * Update package description * Scaffold (#52) * remove split_view package * create title_bar * create sidebar * create content_area * remove titlebar in MainFlutterWindow.swift * Update pubspec.lock * create resizable_pane * create resizable_pane_notifier * Update scaffold.dart * Update macos_ui.dart * Update main.dart * [example] add resizable pane * add dividerColor to MacosThemeData * use BoxDecoration in Sidebar * use SafeArea in ContentArea * update ResizablePane * update scaffold * make `ResizablePane` `const` * make `Sidebar` `const` * make `TitleBar` `const` * make `Scaffold` `const` * Update CHANGELOG.md * Update resizable_pane.dart * add maybeOf to scaffold * Update macos_ui.dart * Update scaffold.dart * add `scaffoldBreakpoint` to `sidebar` * use sidebar breakpoint and toggling in `Scaffold` * use `scaffoldBreakpoint` in `ResizablePane` * update example * Address some requested changes Co-authored-by: Reuben Turner <groovinchip@gmail.com> * Text field (#62) * Implemented TextField And fixed macos resolve color * Formatted code * Update README.md * Border * Fixed text field border to match the latest design * Focused border animation * Fix formatting error * Update placeholder text in demo * Update version, CHANGELOG.md Co-authored-by: Reuben Turner <groovinchip@gmail.com> * Implement mouse cursors (#67) * Implemente mouse cursors * Removed mouse cursor from checkbox and radio button * Implemented mouse cursor for text field * Bump version * Implement Tooltip (#68) * Implement tooltip * Bump version and update readme * Format files * Fixed typo * Update Scaffold images (#72) * Update Scaffold images * Address analyzer warnings * Constructors first * Remove unnecessary statement * Adjust failing score (#75) * Adjust failing score * Address warning * Run dartfmt * Re-adjust scoring * Re-adjust scoring again * Re-adjust scoring again! * Use correct score * Adjust spacing between elements in demo (#76) * Update documentation (#77) * update `resizable_pane_notifier` documentation * update `ScaffoldScope` documentation * Update CHANGELOG.md * Move to v 0.1.0 * Run optimize imports and dartfmt on all files * Fix * Bump version * Fix discrete capacity indicators and format text field * Fix continuous capacity indicator * Update CHANGELOG.md * Implement Label (#93) * Implement label * Updated documentation * Formatted files * Run optimize imports Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com> Co-authored-by: Harshvardhan Singh Bhadouria <66870883+harshvsb1105@users.noreply.github.com> Co-authored-by: Leslie Arkorful <lesliearkorful@gmail.com>

* Update CONTRIBUTING.md * Theming and styles (#8) * Start work on theme Contains a super barebones theme.dart, shamelessly copied from https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/styles/theme.dart * More theme work (9:50 AM March 30) * New macos_app.dart * Placeholer Typography in theme.dart from material * Add some todos/fixmes * Start work on theme Contains a super barebones theme.dart, shamelessly copied from https://github.com/bdlukaa/fluent_ui/blob/master/lib/src/styles/theme.dart * More theme work (9:50 AM March 30) * New macos_app.dart * Placeholer Typography in theme.dart from material * Add some todos/fixmes * Add Apple SF Pro fonts * Add typography.dart * Add basic documentation to typography.dart * Minor tweaks to macos_app.dart * Use CupertinoColors.systemBlue for default color * Rename color to primaryColor * Improvements to theming, root app; first new (experimental) widget: Scaffold! * Remove print * Add not implemented comments * Update README.md with Content section This is very early and is mostly a placeholder * Add animationCurve and mediumAnimationDuration to Style class (#10) Also add repo url to pubspec.yaml * Version 0.0.2 (#11) * Major Updates for Scaffold * Adds SplitView for expanded/shrinking the sidebar * Removed rightSidebar * Lots of customizable properties related to the sidebar * Documentation Additional changes: * Update typography.dart so that the color is properly shown. * Update version * Update README.md * Update CHANGELOG.md * Update license (#12) * MIT License * Use null-safe split-view from git. Tweak Scaffold accordingly . (#13) * Add dart_code_metrics package * Improve code_metrics and address warnings (#17) * Add metrics to configuration * Sort scaffold.dart public members * Sort macos_app.dart public members * Sort theme.dart public members * Sort typography.dart public members * Update to latest code_metrics * Rework on MacosApp (#18) * Rework on MacosApp Reworked MacosApp to use CupertinoApp as a backend. This has several improvements: - Apple-styled scrolling - Using the San Francisco font by default I also added documentation for all the properties * Fixed references iOS -> macOS color -> primaryColor * Update to latest code_metrics and stop requiring alphabetically-sorted class members * Add primaryColor to Style (#19) Renames MacosApp's primaryColor to simply "color" as a result. * Implemented Switch (#21) * Implemented Switch - MacosTheme.maybeOf now can return a nullable value - Added Switch to Example app * Bump version * Implement Progress Indicators * Sort constructors first, run optimize imports * Update progress_indicators.dart docs * Update readme (#23) * Update README.md with Switch, ProgressCircle, and ProgressBar * Reduce image sizes, update indeterminate ProgressCircle file extension * Converted to gif * Fix unreachable content * Theme refactor (#29) * Add primaryColor to Style Renames MacosApp's primaryColor to simply "color" as a result. * Major theme refactor that more closely resembles flutter/material and flutter/cupertino * The `Style` class is now `MacosThemeData` * `MacosTheme` is now a `StatelessWidget` that returns a private `_InheritedMacosTheme`. The static `MacosTheme.of(context)` is now defined here. * `MacosApp` now takes a `theme` and `darkTheme` rather than `style` and `darkStyle`. Additionally, there are minor changes to the way `MacosApp` is built that more closely resemble how `MaterialApp` is built. Inspired by: * material/theme.dart * material/theme_data.dart * material/app.dart * cupertino/theme.dart * Stop setting explicit active colors since the theme will always have a color * Update README.md and CONTRIBUTING.md (#33) * README.md now mentions CONTRIBUTING.md * CONTRIBUTING.md has been updated with branch structure and versioning information * Add pull request template (#34) * Add workflows/pana_analysis.yml (#35) * Add workflows/pana_analysis.yml * Use split_view from pub Author merged my null-safety PR a while back and I forgot to update. This addresses an analyzer warning and also should allow the pana_analysis action to run. * Run `dartfmt -w .` per pana report * Push button (#40) * Stub out buttons with corresponding Styles * Stub out Fields and Labels with corresponding Styles * Stub out Selectors * Placeholder Indicators * Remove stubs for RoundButton and BevelButton Apple docs say not to use these * Start working on PushButton * Get PushButton color from style's primaryColor instead of PushButton's disabledColor Also: * Add button_states.dart * Add PushButtonStyle stub to Style * Add Diagnosticable mixin to PushButtonStyle * Tweak PushButton's disabledColor * Start work on PushButtonStyle * Add color, disabledColor, padding, and borderRadius properties to class with contructor and corresponding debug properties * Include PushButtonStyle when returning default style in theme.dart * Get PushButton color from current style if possible, otherwise fall back to defaults * Add todos for implementing other PushButtonStyle props in PushButton * Use proper padding and border radius for small and large PushButtons * Test PushButton in example app * Export push_button_theme.dart, move todo * Documentation updates * Documentation for PushButtonTheme and PushButtonThemeData * Tweak MacosThemeData documentation * Revert stubs * Update version and CHANGELOG.md * Ensure text color is correct when PushButton is disabled * Add PushButton section to README.md * Try embedding PushButton images as an album * Try embedding PushButton images as an album (2) * Revert to individual images * Improve Typography (#41) * Add letter spacing to all TextStyles that require it Also make headline's letter spacing negative, per spec * Add fontWeights to TextStyles * Update PushButton images in README.md * Update version, CHANGELOG.md * Add `brightnessOf` and `maybeBrightness of` to `MacosTheme` (#43) * Add `brightnessOf` and `maybeBrightness of` Also add documentation to `of` * Update CHANGELOG.md * Add extensions on CupertinoDynamicColor to try and solve what's blocking #30 (#45) * Implemented Level indicator (#30) * Implement capacity indicator * Implemented rating indicator * Implemented relevance indicator * Implemented gesture detector for indicators * Updated theme * Fixed colors I also made some changes to styles/colors.dart * Update colors.dart * Add workflow_dispatch to enable manual runs via gh cli (#46) * Implement RadioButton and Checkbox (#47) * Implemented checkbox * Implemented RadioButton * Updated the theme to match the latest dev * Updated radio button * Update CHANGELOG.md * Fixed radio button in light theme and added shadows * Fixed checkbox light theme * Fixed pubspec * Improved colors * CHORE: bump version * Fixed #49 The GestureDetector applied to capacity indicator should be added inside of the Container. Fixes #49 Bumped version to 0.0.8 * Implemented Help Button (#51) * Implemented Help Button * Implemented Help Button * Implemented Help Button * Implemented Help Button * Implemented Help Button * Update CI with "Format scores json" step (#54) * Update CI with "Format scores json" step Useful for PR's across forks * Docs for new step * fix indentation issue * Readme update (#55) * Documentation about checkbox * Documentation about radio button * Documentation about push button * Documentation about toggle switch * Documentation about indicators * Documentation about help buttons * Squashed commit of the following: commit 617ea07 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:55:11 2021 -0400 spacing commit 4e20615 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:28:51 2021 -0400 Use correct branch name commit e2a2b97 Merge: 80753df df70270 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 20:27:36 2021 -0400 Merge branch 'dev' into gh_pages commit 80753df Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 18:45:40 2021 -0400 Add GH Pages action * change base href * Squashed commit of the following: commit 81b9ac34100622c35cdac752e527a73f49197806 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 22:06:32 2021 -0400 change base href commit d633c3e Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:55:35 2021 -0400 Fix env commit 995f648 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:53:02 2021 -0400 tweak token usage commit 23552c6 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:43:50 2021 -0400 Switch back to my email/username commit 32dc277 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:38:11 2021 -0400 Simplify deploy commit b604090 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:32:04 2021 -0400 Change git config commit d18c134 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:26:49 2021 -0400 Fix indentation commit bcf5ec1 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:25:32 2021 -0400 Remove unnecessary steps and use "working-directory" commit f02cbd7 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:19:58 2021 -0400 Fix paths commit 7dc28be Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:17:17 2021 -0400 Add cd into example commit 3761559 Author: Reuben Turner <groovinchip@gmail.com> Date: Sat May 1 21:13:50 2021 -0400 Try a different action deploying to gh pages * Code Improvements (#58) * Documentation about checkbox * Documentation about radio button * Documentation about push button * Documentation about toggle switch * Documentation about indicators * Documentation about help buttons * Code improvements * Changes * Introduce library.dart Moving flutter exports from macos_ui.dart to library.dart allows documentation to be generated only for files belonging to macos_ui. * Fix placement of package level documentation * Address pana warning Co-authored-by: Reuben Turner <groovinchip@gmail.com> * update base href * Update PR template * Update issue templates * Update package description * Scaffold (#52) * remove split_view package * create title_bar * create sidebar * create content_area * remove titlebar in MainFlutterWindow.swift * Update pubspec.lock * create resizable_pane * create resizable_pane_notifier * Update scaffold.dart * Update macos_ui.dart * Update main.dart * [example] add resizable pane * add dividerColor to MacosThemeData * use BoxDecoration in Sidebar * use SafeArea in ContentArea * update ResizablePane * update scaffold * make `ResizablePane` `const` * make `Sidebar` `const` * make `TitleBar` `const` * make `Scaffold` `const` * Update CHANGELOG.md * Update resizable_pane.dart * add maybeOf to scaffold * Update macos_ui.dart * Update scaffold.dart * add `scaffoldBreakpoint` to `sidebar` * use sidebar breakpoint and toggling in `Scaffold` * use `scaffoldBreakpoint` in `ResizablePane` * update example * Address some requested changes Co-authored-by: Reuben Turner <groovinchip@gmail.com> * Text field (#62) * Implemented TextField And fixed macos resolve color * Formatted code * Update README.md * Border * Fixed text field border to match the latest design * Focused border animation * Fix formatting error * Update placeholder text in demo * Update version, CHANGELOG.md Co-authored-by: Reuben Turner <groovinchip@gmail.com> * Implement mouse cursors (#67) * Implemente mouse cursors * Removed mouse cursor from checkbox and radio button * Implemented mouse cursor for text field * Bump version * Implement Tooltip (#68) * Implement tooltip * Bump version and update readme * Format files * Fixed typo * Update Scaffold images (#72) * Update Scaffold images * Address analyzer warnings * Constructors first * Remove unnecessary statement * Adjust failing score (#75) * Adjust failing score * Address warning * Run dartfmt * Re-adjust scoring * Re-adjust scoring again * Re-adjust scoring again! * Use correct score * Adjust spacing between elements in demo (#76) * Update documentation (#77) * update `resizable_pane_notifier` documentation * update `ScaffoldScope` documentation * Update CHANGELOG.md * Move to v 0.1.0 * Run optimize imports and dartfmt on all files * Fix * Bump version * Fix discrete capacity indicators and format text field * Fix continuous capacity indicator * Update CHANGELOG.md * Implement Label (#93) * Implement label * Updated documentation * Formatted files * Run optimize imports * Theme update (#94) * Theme properties can't be null * Migrated themes to its relative file * Updated color api * Removed animation from theme * Improved documentation and fixed linting issues * Formatted files * Updates * Removed hashCode from typography * Fix text field (#98) * Fix text field * Format files * Bump version * Format scaffold * Address analyzer error/warnings Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com> Co-authored-by: Harshvardhan Singh Bhadouria <66870883+harshvsb1105@users.noreply.github.com> Co-authored-by: Leslie Arkorful <lesliearkorful@gmail.com>

bdlukaa added 4 commits April 15, 2021 19:42

Implement capacity indicator

6cf5ab4

Implemented rating indicator

68cb673

Implemented relevance indicator

679f663

Implemented gesture detector for indicators

1e7d53b

bdlukaa added the enhancement label Apr 16, 2021

GroovinChip added the new widget Requests for new widgets label Apr 16, 2021

GroovinChip linked an issue Apr 17, 2021 that may be closed by this pull request

Add LevelIndicator widget #38

Closed

bdlukaa added 2 commits April 17, 2021 19:35

Merge branch 'bdlukaa-level_indicator' into dev

3e649ec

Merge branch 'dev' into level_indicator

adc5bf4

GroovinChip self-requested a review April 17, 2021 23:40

GroovinChip requested changes Apr 17, 2021

View reviewed changes

lib/src/indicators/rating_indicator.dart Outdated Show resolved Hide resolved

Updated theme

363324b

GroovinChip self-requested a review April 18, 2021 14:33

GroovinChip requested changes Apr 18, 2021

View reviewed changes

GroovinChip mentioned this pull request Apr 18, 2021

Create extension on CupertinoDynamicColor for resolving colors using MacosTheme.maybeBrightnessOf #44

Closed

GroovinChip added a commit that referenced this pull request Apr 18, 2021

Add extensions on CupertinoDynamicColor to try and solve what's block…

df29658

…ing #30

GroovinChip mentioned this pull request Apr 18, 2021

Extensions on CupertinoDynamicColor #45

Merged

5 tasks

GroovinChip added a commit that referenced this pull request Apr 18, 2021

Add extensions on CupertinoDynamicColor to try and solve what's block…

4cffae2

…ing #30 (#45)

bdlukaa added 3 commits April 18, 2021 17:57

Merge branch 'dev' into level_indicator

aa3f66c

Merge branch 'dev' of https://github.com/GroovinChip/macos_ui into le…

142baa9

…vel_indicator

Fixed colors

3340074

I also made some changes to styles/colors.dart

bdlukaa requested a review from GroovinChip April 18, 2021 21:08

Update colors.dart

7f42e4e

GroovinChip approved these changes Apr 19, 2021

View reviewed changes

GroovinChip merged commit 19b9750 into macosui:dev Apr 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implemented Level indicator #30

Implemented Level indicator #30

bdlukaa commented Apr 16, 2021

GroovinChip left a comment

GroovinChip left a comment

bdlukaa commented Apr 18, 2021

GroovinChip commented Apr 18, 2021 •

edited

GroovinChip left a comment

Implemented Level indicator #30

Implemented Level indicator #30

Conversation

bdlukaa commented Apr 16, 2021

GroovinChip left a comment

Choose a reason for hiding this comment

GroovinChip left a comment

Choose a reason for hiding this comment

bdlukaa commented Apr 18, 2021

GroovinChip commented Apr 18, 2021 • edited

GroovinChip left a comment

Choose a reason for hiding this comment

GroovinChip commented Apr 18, 2021 •

edited