portconfigure: Add support for Macports Clang versions 10+ #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
jmroot
requested changes
Apr 26, 2020
… .<minor> version is dropped
cjones051073
force-pushed
the
SupportMacportsClang10
branch
from
20907c4
to
6b60680
Compare
jmroot
approved these changes
Apr 27, 2020
|
@jmroot Thanks for your review. I'll give this a bit longer to allow others to comment, maybe a week or so, but then I think it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor update to
portconfigure.tclto extend the regex used to detect macports provide clang compiler to support the dropping of the minor version from the port name, starting withclang-10(macports/macports-ports#6902).Note that the changes here do not require any changes in the ports tree, either to add the
clang-10compiler or to the resources to add it to the known lists, so can be applied before they are done. However the changes here are required to be available beforemacports-clang-10can be used as a compiler option.Once merged I would propose cherry-picking this to the 2.6 release branch, such as to make it available in the next release from that branch.