pextlib1.0: init err buffer, use err code if empty #186
Conversation
There was a problem hiding this comment.
Looks reasonable, just a typo in a comment ("doesn" -> "doesn't") and in a commit message ("parantheses" -> "parentheses"). My preference would be to move every file toward our customary 4 spaces for indentation, but that's a larger change and doesn't have to happen right now.
|
Oh and the "tests: Fix curl isnewer test broken by braeburn update" commit shouldn't be in this PR. That's already been merged to master. |
We indent this file with tabs and don't add spaces inside of parentheses, so reformat the code that did not use this convention.
curl < 7.60.0 does not initialize the error buffer, and cases have been reported where a curl download failed without the error buffer being set. This was the case on older systems that did not yet have curl 7.60.0, and caused random garbage to be printed. 0-initialize the buffer and check whether the buffer has a useful message before returning it. Generate a substitute message using curl_easy_strerror() from the returned error code if the error buffer is not set. Closes: https://trac.macports.org/ticket/60581
|
I pushed the "curl isnewer" commit to this branch as well to allow the tests to pass. It would have disappeared automatically when merging, but since I'm now pushing another version of the PR for your review comments anyway, I've rebased on top of master. |
Ah. I still have no idea how git works. 😐 |
|
I couldn't reproduce and thus not verify that this does what I wrote it to do, but Travis just triggered such a case and it seems to work as expected: https://paste.macports.org/75dc136dfd83 |
curl < 7.60.0 does not initialize the error buffer, and cases have been reported where a curl download failed without the error buffer being set. This was the case on older systems that did not yet have curl 7.60.0, and caused random garbage to be printed.
0-initialize the buffer and check whether the buffer has a useful message before returning it. Generate a substitute message using
curl_easy_strerror()from the returned error code if the error buffer is not set.Closes: https://trac.macports.org/ticket/60581