Skip to content

Commit

Permalink
cabal: allow building under MacPorts again (#21940)
Browse files Browse the repository at this point in the history
The recently released haskell tar-0.6 introduces some breaking changes
that prevent Cabal from building on MacPorts because of its previous use
of `--allow-newer` in `build.target`. This line was deliberately added
(haskell/cabal#8360 (comment)),
but it's causes persistent build failure.
  • Loading branch information
halostatue committed Dec 26, 2023
1 parent 4c5a6b7 commit 618718b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions lang/cabal/Portfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ PortSystem 1.0

name cabal
version 3.10.2.0
revision 0
revision 1
categories lang haskell devel
platforms darwin
license BSD
Expand Down Expand Up @@ -152,10 +152,8 @@ if {[exists extract.rename]} {
"CABAL_CONFIG=${haskell_cabal.cabal_root}/config" \
"GHC=${prefix}/bin/ghc"

# https://github.com/haskell/cabal/issues/8360#issuecomment-1220918581
build.target ${name}-install \
--project-file=cabal.project.release \
--allow-newer
--project-file=cabal.project.release
build.post_args-append \
--bindir=${prefix}/bin \
--datadir=${prefix}/share/${subport}
Expand Down

1 comment on commit 618718b

@kencu
Copy link
Contributor

@kencu kencu commented on 618718b Jan 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so previously haskell/cabal#8360 “-allow-newer” was required to build cabal, and now it breaks the build.

Don’t need to point out then this is fragile, and likely to break again and need to be re-added at some future time.

Please sign in to comment.