Skip to content

Commit

Permalink
py-numpy: block older Apple Clang
Browse files Browse the repository at this point in the history
rev-bump just in case

They claim to support SIMD but actually don't. Modern NumPy uses SIMD ...
  • Loading branch information
michaelld committed Apr 7, 2020
1 parent a02ad06 commit 8496337
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions python/py-numpy/Portfile
Expand Up @@ -4,6 +4,10 @@ PortSystem 1.0
PortGroup python 1.0
PortGroup github 1.0
PortGroup compilers 1.0
PortGroup compiler_blacklist_versions 1.0

# some older Clang say they support SIMD when they don't

This comment has been minimized.

Copy link
@ryandesign

ryandesign Apr 8, 2020

Contributor

Is this a different problem from the defective CPU capability detection problem that will be fixed in 1.19.0? https://trac.macports.org/ticket/59022

This comment has been minimized.

Copy link
@michaelld

michaelld Apr 9, 2020

Author Contributor

hmmm ... from your bug report I'd say: no. This commit fixes NumPy itself building, nut runtime as seems to be the case in your bug report. As noted here and on Volk -- at least when tested using CMake -- some older Clang report supporting SIMD (e.g., AVX2) but don't. IIRC, the compiler issues a warning rather than an error, which is ignored by CMake. Hence, just blocking those compilers is the way to get NumPy to build inside MacPorts.

compiler.blacklist-append {clang < 900}

name py-numpy
categories-append math
Expand All @@ -17,7 +21,7 @@ github.setup numpy numpy 1.18.2 v
checksums rmd160 ba58a89eb7c1112541e8037dd66774d9b5747ca8 \
sha256 5f684cf7b31f725c121f94dc1c6cd5a8af910ead9e71cddf4af4f16d7ce4d78b \
size 5161709
revision 0
revision 1

if {${name} ne ${subport}} {
# the python PortGroup puts compiler names in build.env and destroot.env
Expand All @@ -44,7 +48,7 @@ if {${name} ne ${subport}} {
checksums rmd160 cbb34cf0981ea142ff45722d05a9daad20a134ea \
sha256 2dce87065d5de1a83485cfb3de5e4e793787890f5c1dcc3536a9cabf2e1620af \
size 4691852
revision 0
revision 1
patchfiles-append patch-numpy_core_setup.py.27.diff \
patch-numpy_tests_test_scripts.py.27.diff \
patch-fcompiler_g95.27.diff
Expand Down

0 comments on commit 8496337

Please sign in to comment.